Re: [PR] Improve benchmark docs [datafusion]

2025-02-24 Thread via GitHub
alamb commented on PR #14820: URL: https://github.com/apache/datafusion/pull/14820#issuecomment-2678977559 > I also just added a commit removing the sentence about commenting on a PR with `/benchmark`-- [@alamb says that's been disabled](https://github.com/apache/datafusion/pull/14818#issue

Re: [PR] Improve benchmark docs [datafusion]

2025-02-24 Thread via GitHub
alamb merged PR #14820: URL: https://github.com/apache/datafusion/pull/14820 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusi

Re: [PR] Improve benchmark docs [datafusion]

2025-02-24 Thread via GitHub
alamb commented on PR #14820: URL: https://github.com/apache/datafusion/pull/14820#issuecomment-2678978219 Thanks again @carols10cents -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] Improve benchmark docs [datafusion]

2025-02-24 Thread via GitHub
carols10cents commented on PR #14820: URL: https://github.com/apache/datafusion/pull/14820#issuecomment-2678702108 I also just added a commit removing the sentence about commenting on a PR with `/benchmark`-- [@alamb says that's been disabled](https://github.com/apache/datafusion/pull/14818

Re: [PR] Improve benchmark docs [datafusion]

2025-02-23 Thread via GitHub
alamb commented on code in PR #14820: URL: https://github.com/apache/datafusion/pull/14820#discussion_r1966797142 ## benchmarks/README.md: ## @@ -243,28 +244,92 @@ The `dfbench` program contains subcommands to run the various benchmarks. When benchmarking, it should always be

[PR] Improve benchmark docs [datafusion]

2025-02-21 Thread via GitHub
carols10cents opened a new pull request, #14820: URL: https://github.com/apache/datafusion/pull/14820 ## Which issue does this PR close? - Closes #14819. ## Rationale for this change I added a new benchmark in #14818. There wasn't documentation on how to add a new benchm