nirnayroy commented on code in PR #15928:
URL: https://github.com/apache/datafusion/pull/15928#discussion_r2159984385
##
datafusion/functions/src/regex/regexpcount.rs:
##
@@ -29,10 +30,10 @@ use datafusion_expr::{
use datafusion_macros::user_doc;
use itertools::izip;
use rege
blaginin commented on code in PR #15928:
URL: https://github.com/apache/datafusion/pull/15928#discussion_r2155683469
##
datafusion/functions/src/regex/regexpinstr.rs:
##
@@ -0,0 +1,804 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lice
blaginin commented on code in PR #15928:
URL: https://github.com/apache/datafusion/pull/15928#discussion_r2155683469
##
datafusion/functions/src/regex/regexpinstr.rs:
##
@@ -0,0 +1,804 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lice
blaginin commented on code in PR #15928:
URL: https://github.com/apache/datafusion/pull/15928#discussion_r2155673833
##
datafusion/functions/src/regex/regexpcount.rs:
##
@@ -29,10 +30,10 @@ use datafusion_expr::{
use datafusion_macros::user_doc;
use itertools::izip;
use regex
nirnayroy commented on code in PR #15928:
URL: https://github.com/apache/datafusion/pull/15928#discussion_r2154895463
##
datafusion/functions/src/regex/regexpcount.rs:
##
@@ -550,7 +550,7 @@ where
}
}
-fn compile_and_cache_regex<'strings, 'cache>(
+pub fn compile_and_cac
nirnayroy commented on code in PR #15928:
URL: https://github.com/apache/datafusion/pull/15928#discussion_r2154383754
##
datafusion/functions/src/regex/regexpinstr.rs:
##
@@ -0,0 +1,804 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lic
blaginin commented on code in PR #15928:
URL: https://github.com/apache/datafusion/pull/15928#discussion_r2153128215
##
datafusion/functions/src/regex/regexpinstr.rs:
##
@@ -0,0 +1,804 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lice
Copilot commented on code in PR #15928:
URL: https://github.com/apache/datafusion/pull/15928#discussion_r2153125391
##
datafusion/functions/benches/regx.rs:
##
@@ -127,6 +128,46 @@ fn criterion_benchmark(c: &mut Criterion) {
})
});
+c.bench_function("regexp_i
blaginin commented on code in PR #15928:
URL: https://github.com/apache/datafusion/pull/15928#discussion_r2153122396
##
datafusion/functions/src/regex/regexpcount.rs:
##
@@ -550,7 +550,7 @@ where
}
}
-fn compile_and_cache_regex<'strings, 'cache>(
+pub fn compile_and_cach
nirnayroy commented on code in PR #15928:
URL: https://github.com/apache/datafusion/pull/15928#discussion_r2141872552
##
datafusion/functions/src/regex/regexpinstr.rs:
##
@@ -0,0 +1,979 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lic
nirnayroy commented on code in PR #15928:
URL: https://github.com/apache/datafusion/pull/15928#discussion_r2141878573
##
datafusion/functions/src/regex/regexpinstr.rs:
##
@@ -0,0 +1,979 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lic
nirnayroy commented on PR #15928:
URL: https://github.com/apache/datafusion/pull/15928#issuecomment-2965393471
Hi @blaginin, thanks for the review and regret the delay in reply. I think I
have rectified a majority of the concerns raised. Please have a look again.
--
This is an automated
nirnayroy commented on code in PR #15928:
URL: https://github.com/apache/datafusion/pull/15928#discussion_r2141879046
##
datafusion/functions/src/regex/regexpinstr.rs:
##
@@ -0,0 +1,979 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lic
nirnayroy commented on code in PR #15928:
URL: https://github.com/apache/datafusion/pull/15928#discussion_r2141870238
##
datafusion/functions/src/regex/regexpinstr.rs:
##
@@ -0,0 +1,979 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lic
nirnayroy commented on code in PR #15928:
URL: https://github.com/apache/datafusion/pull/15928#discussion_r2141882989
##
datafusion/functions/src/regex/regexpinstr.rs:
##
@@ -0,0 +1,979 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lic
nirnayroy commented on code in PR #15928:
URL: https://github.com/apache/datafusion/pull/15928#discussion_r2141880357
##
datafusion/functions/src/regex/regexpinstr.rs:
##
@@ -0,0 +1,979 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lic
nirnayroy commented on code in PR #15928:
URL: https://github.com/apache/datafusion/pull/15928#discussion_r2141877745
##
datafusion/functions/src/regex/regexpinstr.rs:
##
@@ -0,0 +1,979 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lic
nirnayroy commented on code in PR #15928:
URL: https://github.com/apache/datafusion/pull/15928#discussion_r2141871203
##
datafusion/functions/src/regex/regexpinstr.rs:
##
@@ -0,0 +1,979 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lic
alamb commented on PR #15928:
URL: https://github.com/apache/datafusion/pull/15928#issuecomment-2898907668
@Omega359 I wonder if you might have time to review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
blaginin commented on code in PR #15928:
URL: https://github.com/apache/datafusion/pull/15928#discussion_r2101076229
##
datafusion/functions/src/regex/regexpinstr.rs:
##
@@ -0,0 +1,979 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lice
Omega359 commented on PR #15928:
URL: https://github.com/apache/datafusion/pull/15928#issuecomment-2899035444
Of course @alamb, not sure how I missed this one. It may be a day or two
though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
nirnayroy commented on PR #15928:
URL: https://github.com/apache/datafusion/pull/15928#issuecomment-2893026630
fixed formatting error in workflow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
nirnayroy commented on PR #15928:
URL: https://github.com/apache/datafusion/pull/15928#issuecomment-289230
fixed the cippy errors showing up in the workflow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
nirnayroy commented on PR #15928:
URL: https://github.com/apache/datafusion/pull/15928#issuecomment-2890882937
> Thank you for this PR @nirnayroy
>
> Can you please resolve the CI error:
https://github.com/apache/datafusion/actions/runs/14820525339/job/41754009017?pr=15928
>
>
alamb commented on PR #15928:
URL: https://github.com/apache/datafusion/pull/15928#issuecomment-2860276419
Can you please resolve the CI error:
https://github.com/apache/datafusion/actions/runs/14820525339/job/41754009017?pr=15928
> # If you encounter an error, run './dev/update_funct
nirnayroy commented on PR #15928:
URL: https://github.com/apache/datafusion/pull/15928#issuecomment-2849046029
> Thank you. I'm wondering what's the reference system for this function's
behavior (like postgres or others)
The reference system for this function's behaviour is
[post
2010YOUY01 commented on PR #15928:
URL: https://github.com/apache/datafusion/pull/15928#issuecomment-2848931103
Thank you. I'm wondering what's the reference system for this function's
behavior (like postgres or others)
--
This is an automated message from the Apache Git Service.
To respo
nirnayroy opened a new pull request, #15928:
URL: https://github.com/apache/datafusion/pull/15928
## Which issue does this PR close?
- Closes #13009
## Rationale for this change
Implements a regex SQL standard function in datafusion
## What changes are inc
28 matches
Mail list logo
