findepi merged PR #16781:
URL: https://github.com/apache/datafusion/pull/16781
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafu
findepi commented on PR #16781:
URL: https://github.com/apache/datafusion/pull/16781#issuecomment-3084158547
@alamb @timsaucer @kosiew would you like to take a look at new code pushed
here since the time you last reviewed?
--
This is an automated message from the Apache Git Service.
To r
findepi commented on PR #16781:
URL: https://github.com/apache/datafusion/pull/16781#issuecomment-3077368850
> I think it could be reduced in size somewhat by adding `aliases` to the
default implementations.
i'd rather see stuff like aliases and documentation not be part of
ScalardUD
findepi commented on code in PR #16781:
URL: https://github.com/apache/datafusion/pull/16781#discussion_r2209548158
##
datafusion/core/tests/user_defined/user_defined_scalar_functions.rs:
##
@@ -217,6 +217,34 @@ impl ScalarUDFImpl for Simple0ArgsScalarUDF {
fn invoke_with_a
alamb commented on code in PR #16781:
URL: https://github.com/apache/datafusion/pull/16781#discussion_r2208644548
##
datafusion/doc/src/lib.rs:
##
@@ -158,7 +158,7 @@ impl Documentation {
}
}
-#[derive(Debug, Clone, PartialEq)]
+#[derive(Debug, Clone, PartialEq, Hash)]
findepi commented on PR #16781:
URL: https://github.com/apache/datafusion/pull/16781#issuecomment-3073335642
> The approach looks very reasonable, but there is a _lot_ of boiler plate
code. I'm guessing there wasn't an easier way to add some derived traits for
`PartialEq` and `Hash` for the
findepi commented on code in PR #16781:
URL: https://github.com/apache/datafusion/pull/16781#discussion_r2207269417
##
datafusion-examples/examples/function_factory.rs:
##
@@ -153,6 +154,38 @@ impl ScalarUDFImpl for ScalarFunctionWrapper {
fn output_ordering(&self, _input:
findepi commented on code in PR #16781:
URL: https://github.com/apache/datafusion/pull/16781#discussion_r2207256256
##
datafusion/core/tests/user_defined/user_defined_aggregates.rs:
##
@@ -957,6 +957,33 @@ impl AggregateUDFImpl for MetadataBasedAggregateUdf {
curr_s
kosiew commented on code in PR #16781:
URL: https://github.com/apache/datafusion/pull/16781#discussion_r2207167050
##
datafusion-examples/examples/function_factory.rs:
##
@@ -153,6 +154,38 @@ impl ScalarUDFImpl for ScalarFunctionWrapper {
fn output_ordering(&self, _input: &
findepi opened a new pull request, #16781:
URL: https://github.com/apache/datafusion/pull/16781
Default implementation of `ScalarUDFImpl::equals`,
`AggregateUDFImpl::equals` and `WindowUDFImpl::equals` is correct for stateless
functions and those which only state is the `Signature`, which i
10 matches
Mail list logo
