jayzhan211 commented on code in PR #14908:
URL: https://github.com/apache/datafusion/pull/14908#discussion_r1974559047
##
datafusion/functions/src/datetime/to_char.rs:
##
@@ -663,4 +678,51 @@ mod tests {
"Execution error: Format for `to_char` must be non-null Utf8,
alamb merged PR #14908:
URL: https://github.com/apache/datafusion/pull/14908
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on PR #14908:
URL: https://github.com/apache/datafusion/pull/14908#issuecomment-2689523394
Thanks @kosiew and @jayzhan211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
kosiew commented on code in PR #14908:
URL: https://github.com/apache/datafusion/pull/14908#discussion_r1974569034
##
datafusion/functions/src/datetime/to_char.rs:
##
@@ -663,4 +678,51 @@ mod tests {
"Execution error: Format for `to_char` must be non-null Utf8,
rec
Omega359 commented on PR #14908:
URL: https://github.com/apache/datafusion/pull/14908#issuecomment-2688070354
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
kosiew opened a new pull request, #14908:
URL: https://github.com/apache/datafusion/pull/14908
## Which issue does this PR close?
- Closes #14884.
## Rationale for this change
Currently, when passing a NULL value to to_char, it returns an empty string
instead
