Re: [PR] Fix incorrect searched CASE optimization [datafusion]

2025-01-30 Thread via GitHub
findepi commented on code in PR #14349: URL: https://github.com/apache/datafusion/pull/14349#discussion_r1936291719 ## datafusion/sqllogictest/test_files/case.slt: ## @@ -289,12 +289,22 @@ query B select case when a=1 then false end from foo; false -false -false -false -

Re: [PR] Fix incorrect searched CASE optimization [datafusion]

2025-01-30 Thread via GitHub
findepi merged PR #14349: URL: https://github.com/apache/datafusion/pull/14349 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafu

Re: [PR] Fix incorrect searched CASE optimization [datafusion]

2025-01-30 Thread via GitHub
alamb commented on code in PR #14349: URL: https://github.com/apache/datafusion/pull/14349#discussion_r1936101942 ## datafusion/sqllogictest/test_files/case.slt: ## @@ -289,12 +289,22 @@ query B select case when a=1 then false end from foo; false -false -false -false -fa

Re: [PR] Fix incorrect searched CASE optimization [datafusion]

2025-01-29 Thread via GitHub
findepi closed pull request #14349: Fix incorrect searched CASE optimization URL: https://github.com/apache/datafusion/pull/14349 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Fix incorrect searched CASE optimization [datafusion]

2025-01-29 Thread via GitHub
findepi commented on code in PR #14349: URL: https://github.com/apache/datafusion/pull/14349#discussion_r1933432132 ## datafusion/sqllogictest/test_files/case.slt: ## @@ -289,12 +289,22 @@ query B select case when a=1 then false end from foo; false -false -false -false -

[PR] Fix incorrect searched CASE optimization [datafusion]

2025-01-28 Thread via GitHub
findepi opened a new pull request, #14349: URL: https://github.com/apache/datafusion/pull/14349 There is an optimization for searched CASE where values are of boolean type. It was converting the expression like CASE WHEN X THEN A WHEN Y THEN B ..