Re: [PR] Fix error on `array_distinct` when input is empty #13810 [datafusion]

2025-01-08 Thread via GitHub
comphead merged PR #14034: URL: https://github.com/apache/datafusion/pull/14034 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@dataf

Re: [PR] Fix error on `array_distinct` when input is empty #13810 [datafusion]

2025-01-08 Thread via GitHub
cht42 commented on PR #14034: URL: https://github.com/apache/datafusion/pull/14034#issuecomment-2577023771 added back the early check on empty arrays and added a test case -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] Fix error on `array_distinct` when input is empty #13810 [datafusion]

2025-01-07 Thread via GitHub
comphead commented on code in PR #14034: URL: https://github.com/apache/datafusion/pull/14034#discussion_r1905726601 ## datafusion/functions-nested/src/set_ops.rs: ## @@ -513,9 +513,6 @@ fn general_array_distinct( array: &GenericListArray, field: &FieldRef, ) -> Resul

Re: [PR] Fix error on `array_distinct` when input is empty #13810 [datafusion]

2025-01-07 Thread via GitHub
cht42 commented on PR #14034: URL: https://github.com/apache/datafusion/pull/14034#issuecomment-2575530332 > Thanks @cht42 ! > > What does FLUP stand for 🤔 My google fu doesn't seem to be able to find anythihg relevant: https://www.google.com/search?q=flup&oq=flup Means: **F**o