Re: [PR] Fix empty aggregation function count() in Substrait [datafusion]

2025-04-05 Thread via GitHub
jayzhan211 commented on PR #15345: URL: https://github.com/apache/datafusion/pull/15345#issuecomment-2745019573 Thanks all! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Fix empty aggregation function count() in Substrait [datafusion]

2025-04-04 Thread via GitHub
jayzhan211 commented on code in PR #15345: URL: https://github.com/apache/datafusion/pull/15345#discussion_r2007610582 ## datafusion/substrait/src/logical_plan/consumer.rs: ## @@ -1975,6 +1975,13 @@ pub async fn from_substrait_agg_func( let args = from_substrait_func_args

Re: [PR] Fix empty aggregation function count() in Substrait [datafusion]

2025-03-24 Thread via GitHub
gabotechs commented on code in PR #15345: URL: https://github.com/apache/datafusion/pull/15345#discussion_r2007643274 ## datafusion/substrait/src/logical_plan/consumer.rs: ## @@ -1975,6 +1975,13 @@ pub async fn from_substrait_agg_func( let args = from_substrait_func_args(

Re: [PR] Fix empty aggregation function count() in Substrait [datafusion]

2025-03-21 Thread via GitHub
jayzhan211 merged PR #15345: URL: https://github.com/apache/datafusion/pull/15345 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@dat

Re: [PR] Fix empty aggregation function count() in Substrait [datafusion]

2025-03-21 Thread via GitHub
alamb commented on code in PR #15345: URL: https://github.com/apache/datafusion/pull/15345#discussion_r2008169237 ## datafusion/substrait/src/logical_plan/consumer.rs: ## @@ -1975,6 +1975,15 @@ pub async fn from_substrait_agg_func( let args = from_substrait_func_args(cons

Re: [PR] Fix empty aggregation function count() in Substrait [datafusion]

2025-03-21 Thread via GitHub
gabotechs commented on code in PR #15345: URL: https://github.com/apache/datafusion/pull/15345#discussion_r2007641902 ## datafusion/substrait/src/logical_plan/consumer.rs: ## @@ -1975,6 +1975,13 @@ pub async fn from_substrait_agg_func( let args = from_substrait_func_args(

Re: [PR] Fix empty aggregation function count() in Substrait [datafusion]

2025-03-21 Thread via GitHub
jayzhan211 commented on code in PR #15345: URL: https://github.com/apache/datafusion/pull/15345#discussion_r2007611748 ## datafusion/substrait/src/logical_plan/consumer.rs: ## @@ -1975,6 +1975,13 @@ pub async fn from_substrait_agg_func( let args = from_substrait_func_args

Re: [PR] Fix empty aggregation function count() in Substrait [datafusion]

2025-03-21 Thread via GitHub
gabotechs commented on code in PR #15345: URL: https://github.com/apache/datafusion/pull/15345#discussion_r2007244821 ## datafusion/substrait/src/logical_plan/consumer.rs: ## @@ -1975,6 +1975,13 @@ pub async fn from_substrait_agg_func( let args = from_substrait_func_args(

Re: [PR] Fix empty aggregation function count() in Substrait [datafusion]

2025-03-21 Thread via GitHub
geoffreyclaude commented on code in PR #15345: URL: https://github.com/apache/datafusion/pull/15345#discussion_r2007056372 ## datafusion/substrait/src/logical_plan/consumer.rs: ## @@ -1975,6 +1975,13 @@ pub async fn from_substrait_agg_func( let args = from_substrait_func_

[PR] Fix empty aggregation function count() in Substrait [datafusion]

2025-03-21 Thread via GitHub
gabotechs opened a new pull request, #15345: URL: https://github.com/apache/datafusion/pull/15345 ## Which issue does this PR close? - Closes #15344 ## Rationale for this change Fixing empty `count()` aggregation functions provided through Substrait ## What changes