findepi merged PR #14356:
URL: https://github.com/apache/datafusion/pull/14356
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafu
findepi commented on code in PR #14356:
URL: https://github.com/apache/datafusion/pull/14356#discussion_r1937076628
##
datafusion/expr/src/logical_plan/plan.rs:
##
@@ -2645,6 +2643,106 @@ pub struct Union {
pub schema: DFSchemaRef,
}
+impl Union {
+/// Constructs new
findepi commented on code in PR #14356:
URL: https://github.com/apache/datafusion/pull/14356#discussion_r1937072353
##
datafusion/expr/src/logical_plan/plan.rs:
##
@@ -2645,6 +2643,106 @@ pub struct Union {
pub schema: DFSchemaRef,
}
+impl Union {
+/// Constructs new
findepi commented on code in PR #14356:
URL: https://github.com/apache/datafusion/pull/14356#discussion_r1937065602
##
datafusion/expr/src/logical_plan/plan.rs:
##
@@ -2645,6 +2643,106 @@ pub struct Union {
pub schema: DFSchemaRef,
}
+impl Union {
+/// Constructs new
findepi commented on code in PR #14356:
URL: https://github.com/apache/datafusion/pull/14356#discussion_r1937065983
##
datafusion/expr/src/logical_plan/plan.rs:
##
@@ -2645,6 +2643,106 @@ pub struct Union {
pub schema: DFSchemaRef,
}
+impl Union {
+/// Constructs new
wiedld commented on code in PR #14356:
URL: https://github.com/apache/datafusion/pull/14356#discussion_r1936790068
##
datafusion/expr/src/logical_plan/plan.rs:
##
@@ -2645,6 +2643,106 @@ pub struct Union {
pub schema: DFSchemaRef,
}
+impl Union {
+/// Constructs new
wiedld commented on code in PR #14356:
URL: https://github.com/apache/datafusion/pull/14356#discussion_r1936767438
##
datafusion/expr/src/logical_plan/plan.rs:
##
@@ -2645,6 +2643,106 @@ pub struct Union {
pub schema: DFSchemaRef,
}
+impl Union {
+/// Constructs new
alamb commented on code in PR #14356:
URL: https://github.com/apache/datafusion/pull/14356#discussion_r1936302988
##
datafusion/expr/src/logical_plan/plan.rs:
##
@@ -2645,6 +2643,106 @@ pub struct Union {
pub schema: DFSchemaRef,
}
+impl Union {
+/// Constructs new U
alamb commented on code in PR #14356:
URL: https://github.com/apache/datafusion/pull/14356#discussion_r1936301257
##
datafusion/expr/src/logical_plan/plan.rs:
##
@@ -2645,6 +2643,106 @@ pub struct Union {
pub schema: DFSchemaRef,
}
+impl Union {
+/// Constructs new U
findepi commented on code in PR #14356:
URL: https://github.com/apache/datafusion/pull/14356#discussion_r1936298445
##
datafusion/sqllogictest/test_files/union.slt:
##
@@ -836,3 +836,18 @@ physical_plan
# Clean up after the test
statement ok
drop table aggregate_test_100;
+
+
findepi commented on code in PR #14356:
URL: https://github.com/apache/datafusion/pull/14356#discussion_r1936297998
##
datafusion/expr/src/logical_plan/plan.rs:
##
@@ -2645,6 +2643,106 @@ pub struct Union {
pub schema: DFSchemaRef,
}
+impl Union {
+/// Constructs new
findepi commented on code in PR #14356:
URL: https://github.com/apache/datafusion/pull/14356#discussion_r1936295124
##
datafusion/expr/src/logical_plan/plan.rs:
##
@@ -2645,6 +2643,106 @@ pub struct Union {
pub schema: DFSchemaRef,
}
+impl Union {
+/// Constructs new
alamb commented on code in PR #14356:
URL: https://github.com/apache/datafusion/pull/14356#discussion_r1936081492
##
datafusion/expr/src/logical_plan/plan.rs:
##
@@ -2645,6 +2643,106 @@ pub struct Union {
pub schema: DFSchemaRef,
}
+impl Union {
+/// Constructs new U
findepi commented on PR #14356:
URL: https://github.com/apache/datafusion/pull/14356#issuecomment-2622185174
Thanks @Omega359 for your review, addressed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
findepi commented on code in PR #14356:
URL: https://github.com/apache/datafusion/pull/14356#discussion_r1934247452
##
datafusion/expr/src/logical_plan/plan.rs:
##
@@ -2645,6 +2643,106 @@ pub struct Union {
pub schema: DFSchemaRef,
}
+impl Union {
+/// Constructs new
findepi commented on code in PR #14356:
URL: https://github.com/apache/datafusion/pull/14356#discussion_r1934244570
##
datafusion/expr/src/logical_plan/plan.rs:
##
@@ -2645,6 +2643,106 @@ pub struct Union {
pub schema: DFSchemaRef,
}
+impl Union {
+/// Constructs new
Omega359 commented on PR #14356:
URL: https://github.com/apache/datafusion/pull/14356#issuecomment-2622107955
I ran the sqlite tests against this branch with no changes so the tests in
there did not cover this case.
--
This is an automated message from the Apache Git Service.
To respond t
Omega359 commented on code in PR #14356:
URL: https://github.com/apache/datafusion/pull/14356#discussion_r1934137664
##
datafusion/expr/src/logical_plan/plan.rs:
##
@@ -2645,6 +2643,106 @@ pub struct Union {
pub schema: DFSchemaRef,
}
+impl Union {
+/// Constructs ne
Omega359 commented on code in PR #14356:
URL: https://github.com/apache/datafusion/pull/14356#discussion_r1934134314
##
datafusion/expr/src/logical_plan/plan.rs:
##
@@ -2645,6 +2643,106 @@ pub struct Union {
pub schema: DFSchemaRef,
}
+impl Union {
+/// Constructs ne
alamb commented on PR #14356:
URL: https://github.com/apache/datafusion/pull/14356#issuecomment-2621877094
@wiedld can you also please review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
findepi commented on PR #14356:
URL: https://github.com/apache/datafusion/pull/14356#issuecomment-2621752435
cc @felipecrv, @Omega359
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
findepi opened a new pull request, #14356:
URL: https://github.com/apache/datafusion/pull/14356
This commit fixes two bugs related to UNION handling
- when constructing union plan nullability of the other union branch was
ignored, thus resulting field could easily have incorrect n
22 matches
Mail list logo
