kczimm commented on code in PR #15743:
URL: https://github.com/apache/datafusion/pull/15743#discussion_r2084740956
##
datafusion/sql/tests/sql_integration.rs:
##
@@ -4607,82 +4607,58 @@ fn test_prepare_statement_to_plan_params_as_constants()
{
}
#[test]
-fn test_infer_types
qstommyshu commented on code in PR #15743:
URL: https://github.com/apache/datafusion/pull/15743#discussion_r2083691379
##
datafusion/sql/tests/sql_integration.rs:
##
@@ -4607,82 +4607,58 @@ fn test_prepare_statement_to_plan_params_as_constants()
{
}
#[test]
-fn test_infer_t
qstommyshu commented on code in PR #15743:
URL: https://github.com/apache/datafusion/pull/15743#discussion_r2083691379
##
datafusion/sql/tests/sql_integration.rs:
##
@@ -4607,82 +4607,58 @@ fn test_prepare_statement_to_plan_params_as_constants()
{
}
#[test]
-fn test_infer_t
brayanjuls commented on code in PR #15743:
URL: https://github.com/apache/datafusion/pull/15743#discussion_r2083604044
##
datafusion/sql/tests/sql_integration.rs:
##
@@ -4607,82 +4607,58 @@ fn test_prepare_statement_to_plan_params_as_constants()
{
}
#[test]
-fn test_infer_t
qstommyshu commented on code in PR #15743:
URL: https://github.com/apache/datafusion/pull/15743#discussion_r2083261051
##
datafusion/sql/src/statement.rs:
##
@@ -710,6 +710,7 @@ impl SqlToRel<'_, S> {
*statement,
&mut planner_context,
brayanjuls commented on code in PR #15743:
URL: https://github.com/apache/datafusion/pull/15743#discussion_r2080637131
##
datafusion/sql/tests/sql_integration.rs:
##
@@ -4695,34 +4698,37 @@ fn test_infer_types_from_between_predicate() {
// replace params with values
brayanjuls commented on code in PR #15743:
URL: https://github.com/apache/datafusion/pull/15743#discussion_r2080604387
##
datafusion/sql/src/statement.rs:
##
@@ -710,6 +710,25 @@ impl SqlToRel<'_, S> {
*statement,
&mut planner_context,
brayanjuls commented on code in PR #15743:
URL: https://github.com/apache/datafusion/pull/15743#discussion_r2080601400
##
datafusion/sql/src/statement.rs:
##
@@ -710,6 +710,25 @@ impl SqlToRel<'_, S> {
*statement,
&mut planner_context,
brayanjuls commented on code in PR #15743:
URL: https://github.com/apache/datafusion/pull/15743#discussion_r2080599583
##
datafusion/sql/src/statement.rs:
##
@@ -710,6 +710,25 @@ impl SqlToRel<'_, S> {
*statement,
&mut planner_context,
kczimm commented on code in PR #15743:
URL: https://github.com/apache/datafusion/pull/15743#discussion_r2080478955
##
datafusion/sql/tests/sql_integration.rs:
##
@@ -4695,34 +4698,37 @@ fn test_infer_types_from_between_predicate() {
// replace params with values
let
alamb commented on PR #15743:
URL: https://github.com/apache/datafusion/pull/15743#issuecomment-2860184929
Since @kczimm is working on this feature I think, maybe he has some
thoughts about how this PR should be structured
--
This is an automated message from the Apache Git Service.
To r
alamb commented on code in PR #15743:
URL: https://github.com/apache/datafusion/pull/15743#discussion_r2075226062
##
datafusion/sql/src/statement.rs:
##
@@ -710,6 +710,25 @@ impl SqlToRel<'_, S> {
*statement,
&mut planner_context,
qstommyshu commented on code in PR #15743:
URL: https://github.com/apache/datafusion/pull/15743#discussion_r2074561403
##
datafusion/sql/src/statement.rs:
##
@@ -710,6 +710,25 @@ impl SqlToRel<'_, S> {
*statement,
&mut planner_context,
qstommyshu commented on PR #15743:
URL: https://github.com/apache/datafusion/pull/15743#issuecomment-2852990157
Hi @brayanjuls,
Thanks for the clever fix! For this issue, I suggest we keep our changes
limited to the test file. Modifying
[datafusion/sql/src/statement.rs](https://githu
qstommyshu commented on code in PR #15743:
URL: https://github.com/apache/datafusion/pull/15743#discussion_r2054496588
##
datafusion/sql/tests/sql_integration.rs:
##
@@ -4673,16 +4675,17 @@ fn test_infer_types_from_predicate() {
}
#[test]
-fn test_infer_types_from_between_pr
qstommyshu commented on code in PR #15743:
URL: https://github.com/apache/datafusion/pull/15743#discussion_r2054496588
##
datafusion/sql/tests/sql_integration.rs:
##
@@ -4673,16 +4675,17 @@ fn test_infer_types_from_predicate() {
}
#[test]
-fn test_infer_types_from_between_pr
brayanjuls commented on code in PR #15743:
URL: https://github.com/apache/datafusion/pull/15743#discussion_r2054252874
##
datafusion/sql/tests/sql_integration.rs:
##
@@ -4673,16 +4675,17 @@ fn test_infer_types_from_predicate() {
}
#[test]
-fn test_infer_types_from_between_pr
qstommyshu commented on code in PR #15743:
URL: https://github.com/apache/datafusion/pull/15743#discussion_r2054082743
##
datafusion/sql/tests/sql_integration.rs:
##
@@ -4673,16 +4675,17 @@ fn test_infer_types_from_predicate() {
}
#[test]
-fn test_infer_types_from_between_pr
qstommyshu commented on code in PR #15743:
URL: https://github.com/apache/datafusion/pull/15743#discussion_r2054082743
##
datafusion/sql/tests/sql_integration.rs:
##
@@ -4673,16 +4675,17 @@ fn test_infer_types_from_predicate() {
}
#[test]
-fn test_infer_types_from_between_pr
qstommyshu commented on code in PR #15743:
URL: https://github.com/apache/datafusion/pull/15743#discussion_r2054082743
##
datafusion/sql/tests/sql_integration.rs:
##
@@ -4673,16 +4675,17 @@ fn test_infer_types_from_predicate() {
}
#[test]
-fn test_infer_types_from_between_pr
brayanjuls commented on code in PR #15743:
URL: https://github.com/apache/datafusion/pull/15743#discussion_r2052987238
##
datafusion/sql/tests/sql_integration.rs:
##
@@ -4673,16 +4675,17 @@ fn test_infer_types_from_predicate() {
}
#[test]
-fn test_infer_types_from_between_pr
brayanjuls commented on code in PR #15743:
URL: https://github.com/apache/datafusion/pull/15743#discussion_r2048130471
##
datafusion/sql/tests/sql_integration.rs:
##
@@ -4673,16 +4675,17 @@ fn test_infer_types_from_predicate() {
}
#[test]
-fn test_infer_types_from_between_pr
brayanjuls opened a new pull request, #15743:
URL: https://github.com/apache/datafusion/pull/15743
## Which issue does this PR close?
- Closes #15577
## Rationale for this change
This intent to correct issues on the prepare statements infer type tests.
Currently they are
brayanjuls commented on code in PR #15743:
URL: https://github.com/apache/datafusion/pull/15743#discussion_r2048130471
##
datafusion/sql/tests/sql_integration.rs:
##
@@ -4673,16 +4675,17 @@ fn test_infer_types_from_predicate() {
}
#[test]
-fn test_infer_types_from_between_pr
24 matches
Mail list logo
