Re: [PR] Fix `limit` in subqueries [datafusion-sqlparser-rs]

2025-07-18 Thread via GitHub
alamb commented on PR #1899: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1899#issuecomment-3089305218 I tried to backport this code to 0.56.0 and I think it is not "semver" compatible (we need to release this as 0.57.0). I will do so See more details on - https://

Re: [PR] Fix `limit` in subqueries [datafusion-sqlparser-rs]

2025-06-28 Thread via GitHub
Dimchikkk commented on PR #1899: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1899#issuecomment-3015983460 > @Dimchikkk I don't have a plan myself -- I think it will be driven by someone who needs features of sqlparser in a new version of DataFusion. Perhaps you can help out

Re: [PR] Fix `limit` in subqueries [datafusion-sqlparser-rs]

2025-06-23 Thread via GitHub
Dimchikkk commented on PR #1899: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1899#issuecomment-2994258750 @alamb I'm aware that DataFusion isn’t on 0.56 yet. However, in order to upgrade it to 0.56, this fix would need to be backported. So I’m wondering: what’s the plan? Wi

Re: [PR] Fix `limit` in subqueries [datafusion-sqlparser-rs]

2025-06-23 Thread via GitHub
alamb commented on PR #1899: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1899#issuecomment-2995860448 I didn't hold 0.57.0 as the bug wasn't introduced in 0.57.0 -- instead it seems to have been introduced in 0.56.0 -- so in my mind it makes sense to just keep pushing forwa

Re: [PR] Fix `limit` in subqueries [datafusion-sqlparser-rs]

2025-06-23 Thread via GitHub
alamb commented on PR #1899: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1899#issuecomment-2995850581 > @alamb I'm aware that DataFusion isn’t on 0.56 yet. However, in order to upgrade it to 0.56, this fix would need to be backported. So I’m wondering: what’s the plan? Will

Re: [PR] Fix `limit` in subqueries [datafusion-sqlparser-rs]

2025-06-22 Thread via GitHub
alamb commented on PR #1899: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1899#issuecomment-2994195905 > @iffyio Thanks for merging. @alamb Could this fix be backported to 0.56, or will DataFusion move straight to 0.57? DataFusion hasn't updated to 0.56 yet - https:

Re: [PR] Fix `limit` in subqueries [datafusion-sqlparser-rs]

2025-06-22 Thread via GitHub
iffyio commented on PR #1899: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1899#issuecomment-2994227284 Ah yeah a new release candidate sounds reasonable given 0.57 isn't out yet -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Fix `limit` in subqueries [datafusion-sqlparser-rs]

2025-06-22 Thread via GitHub
iffyio merged PR #1899: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1899 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

Re: [PR] Fix `limit` in subqueries [datafusion-sqlparser-rs]

2025-06-22 Thread via GitHub
Dimchikkk commented on PR #1899: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1899#issuecomment-2994075201 @iffyio Thanks for merging. @alamb Could this fix be backported to 0.56, or will DataFusion move straight to 0.57? -- This is an automated message from the Apache

[PR] fix `limit` in subqueries [datafusion-sqlparser-rs]

2025-06-20 Thread via GitHub
Dimchikkk opened a new pull request, #1899: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1899 Fixes https://github.com/apache/datafusion-sqlparser-rs/issues/1898. The bug was introduced in https://github.com/apache/datafusion-sqlparser-rs/pull/1793 I think. -- This i