xudong963 commented on PR #14569:
URL: https://github.com/apache/datafusion/pull/14569#issuecomment-2648194193
Thanks all, let's go!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
xudong963 merged PR #14569:
URL: https://github.com/apache/datafusion/pull/14569
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@data
xudong963 commented on PR #14569:
URL: https://github.com/apache/datafusion/pull/14569#issuecomment-2648148207
> This makes sense to me -- thank you @xudong963
>
> In general it seems like we have a class of bugs related to removing
`fetch` -- maybe we should re-evaluate `enforce_sort
xudong963 commented on code in PR #14569:
URL: https://github.com/apache/datafusion/pull/14569#discussion_r1948961642
##
datafusion/core/tests/physical_optimizer/enforce_sorting.rs:
##
@@ -1943,6 +1943,30 @@ async fn test_remove_unnecessary_spm1() -> Result<()> {
Ok(())
}
xudong963 commented on code in PR #14569:
URL: https://github.com/apache/datafusion/pull/14569#discussion_r1948961642
##
datafusion/core/tests/physical_optimizer/enforce_sorting.rs:
##
@@ -1943,6 +1943,30 @@ async fn test_remove_unnecessary_spm1() -> Result<()> {
Ok(())
}
xudong963 commented on code in PR #14569:
URL: https://github.com/apache/datafusion/pull/14569#discussion_r1948960557
##
datafusion/core/tests/physical_optimizer/enforce_sorting.rs:
##
@@ -1943,6 +1943,30 @@ async fn test_remove_unnecessary_spm1() -> Result<()> {
Ok(())
}
xudong963 commented on code in PR #14569:
URL: https://github.com/apache/datafusion/pull/14569#discussion_r1948920668
##
datafusion/physical-optimizer/src/enforce_sorting/mod.rs:
##
@@ -373,9 +373,10 @@ pub fn ensure_sorting(
return adjust_window_sort_removal(requiremen
zhuqi-lucas commented on code in PR #14569:
URL: https://github.com/apache/datafusion/pull/14569#discussion_r1948599651
##
datafusion/physical-optimizer/src/enforce_sorting/mod.rs:
##
@@ -373,9 +373,10 @@ pub fn ensure_sorting(
return adjust_window_sort_removal(requirem
zhuqi-lucas commented on code in PR #14569:
URL: https://github.com/apache/datafusion/pull/14569#discussion_r1948589383
##
datafusion/core/tests/physical_optimizer/enforce_sorting.rs:
##
@@ -1943,6 +1943,30 @@ async fn test_remove_unnecessary_spm1() -> Result<()> {
Ok(())
zhuqi-lucas commented on code in PR #14569:
URL: https://github.com/apache/datafusion/pull/14569#discussion_r1948589383
##
datafusion/core/tests/physical_optimizer/enforce_sorting.rs:
##
@@ -1943,6 +1943,30 @@ async fn test_remove_unnecessary_spm1() -> Result<()> {
Ok(())
zhuqi-lucas commented on code in PR #14569:
URL: https://github.com/apache/datafusion/pull/14569#discussion_r1948589383
##
datafusion/core/tests/physical_optimizer/enforce_sorting.rs:
##
@@ -1943,6 +1943,30 @@ async fn test_remove_unnecessary_spm1() -> Result<()> {
Ok(())
xudong963 commented on code in PR #14569:
URL: https://github.com/apache/datafusion/pull/14569#discussion_r1948528835
##
datafusion/physical-optimizer/src/enforce_sorting/mod.rs:
##
@@ -373,9 +373,10 @@ pub fn ensure_sorting(
return adjust_window_sort_removal(requiremen
xudong963 commented on code in PR #14569:
URL: https://github.com/apache/datafusion/pull/14569#discussion_r1948526926
##
datafusion/core/tests/physical_optimizer/enforce_sorting.rs:
##
@@ -1943,6 +1943,30 @@ async fn test_remove_unnecessary_spm1() -> Result<()> {
Ok(())
}
xudong963 commented on code in PR #14569:
URL: https://github.com/apache/datafusion/pull/14569#discussion_r1948524638
##
datafusion/core/tests/physical_optimizer/enforce_sorting.rs:
##
@@ -1943,6 +1943,30 @@ async fn test_remove_unnecessary_spm1() -> Result<()> {
Ok(())
}
zhuqi-lucas commented on code in PR #14569:
URL: https://github.com/apache/datafusion/pull/14569#discussion_r1948494619
##
datafusion/core/tests/physical_optimizer/enforce_sorting.rs:
##
@@ -1943,6 +1943,30 @@ async fn test_remove_unnecessary_spm1() -> Result<()> {
Ok(())
zhuqi-lucas commented on code in PR #14569:
URL: https://github.com/apache/datafusion/pull/14569#discussion_r1948492572
##
datafusion/core/tests/physical_optimizer/enforce_sorting.rs:
##
@@ -1943,6 +1943,30 @@ async fn test_remove_unnecessary_spm1() -> Result<()> {
Ok(())
xudong963 opened a new pull request, #14569:
URL: https://github.com/apache/datafusion/pull/14569
## Rationale for this change
It's clear that fetch will miss after removing SPM
## What changes are included in this PR?
If SPM is with fetch, we won't remove it.
xudong963 closed pull request #14568: Fix: limit is missing after removing SPM
URL: https://github.com/apache/datafusion/pull/14568
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
xudong963 opened a new pull request, #14568:
URL: https://github.com/apache/datafusion/pull/14568
## Which issue does this PR close?
- Closes #.
## Rationale for this change
It's clear that `fetch` will miss after removing SPM
## What changes are in
19 matches
Mail list logo
