alamb commented on PR #16066:
URL: https://github.com/apache/datafusion/pull/16066#issuecomment-3128985922
I am not sure, I merged up to main and started the CI again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
alamb commented on code in PR #16066:
URL: https://github.com/apache/datafusion/pull/16066#discussion_r2237680006
##
datafusion/sqllogictest/test_files/aggregate.slt:
##
@@ -690,6 +690,31 @@ SELECT c2, var_samp(c12) FILTER (WHERE c12 > 0.95) FROM
aggregate_test_100 GROUP
4 NUL
alamb commented on code in PR #16066:
URL: https://github.com/apache/datafusion/pull/16066#discussion_r2237674016
##
datafusion/sqllogictest/test_files/aggregate.slt:
##
@@ -690,6 +690,31 @@ SELECT c2, var_samp(c12) FILTER (WHERE c12 > 0.95) FROM
aggregate_test_100 GROUP
4 NUL
Col-Waltz commented on PR #16066:
URL: https://github.com/apache/datafusion/pull/16066#issuecomment-3104751477
Thanks again for your comment, I tried to compact the code but it leads to
additional trait implementations in another parts of the project, so I assumed
that it will be better to
Col-Waltz commented on code in PR #16066:
URL: https://github.com/apache/datafusion/pull/16066#discussion_r2223769176
##
datafusion/optimizer/src/common_subexpr_eliminate.rs:
##
@@ -316,6 +316,19 @@ impl CommonSubexprEliminate {
} => {
Col-Waltz commented on code in PR #16066:
URL: https://github.com/apache/datafusion/pull/16066#discussion_r2223769176
##
datafusion/optimizer/src/common_subexpr_eliminate.rs:
##
@@ -316,6 +316,19 @@ impl CommonSubexprEliminate {
} => {
github-actions[bot] commented on PR #16066:
URL: https://github.com/apache/datafusion/pull/16066#issuecomment-3086432006
Thank you for your contribution. Unfortunately, this pull request is stale
because it has been open 60 days with no activity. Please remove the stale
label or comment or
Col-Waltz commented on code in PR #16066:
URL: https://github.com/apache/datafusion/pull/16066#discussion_r2093603729
##
datafusion/optimizer/src/common_subexpr_eliminate.rs:
##
@@ -316,6 +316,19 @@ impl CommonSubexprEliminate {
} => {
Col-Waltz commented on code in PR #16066:
URL: https://github.com/apache/datafusion/pull/16066#discussion_r2093603729
##
datafusion/optimizer/src/common_subexpr_eliminate.rs:
##
@@ -316,6 +316,19 @@ impl CommonSubexprEliminate {
} => {
Col-Waltz commented on code in PR #16066:
URL: https://github.com/apache/datafusion/pull/16066#discussion_r2093603729
##
datafusion/optimizer/src/common_subexpr_eliminate.rs:
##
@@ -316,6 +316,19 @@ impl CommonSubexprEliminate {
} => {
Col-Waltz commented on code in PR #16066:
URL: https://github.com/apache/datafusion/pull/16066#discussion_r2093603729
##
datafusion/optimizer/src/common_subexpr_eliminate.rs:
##
@@ -316,6 +316,19 @@ impl CommonSubexprEliminate {
} => {
alamb commented on code in PR #16066:
URL: https://github.com/apache/datafusion/pull/16066#discussion_r2093568326
##
datafusion/optimizer/src/common_subexpr_eliminate.rs:
##
@@ -316,6 +316,19 @@ impl CommonSubexprEliminate {
} => {
l
Col-Waltz opened a new pull request, #16066:
URL: https://github.com/apache/datafusion/pull/16066
## Which issue does this PR close?
- Closes https://github.com/apache/datafusion/issues/15291.
## Rationale for this change
Common_sub_expression_eliminate rule failed with e
13 matches
Mail list logo
