alamb commented on code in PR #15852:
URL: https://github.com/apache/datafusion/pull/15852#discussion_r2065176521
##
datafusion/physical-plan/src/aggregates/mod.rs:
##
@@ -941,49 +994,15 @@ impl ExecutionPlan for AggregateExec {
}
fn statistics(&self) -> Result {
-
xudong963 commented on code in PR #15852:
URL: https://github.com/apache/datafusion/pull/15852#discussion_r2062983955
##
datafusion/physical-plan/src/execution_plan.rs:
##
@@ -430,6 +430,32 @@ pub trait ExecutionPlan: Debug + DisplayAs + Send + Sync {
Ok(Statistics::new
xudong963 commented on PR #15852:
URL: https://github.com/apache/datafusion/pull/15852#issuecomment-2834656400
Github is down, my recent update is delayed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
xudong963 commented on code in PR #15852:
URL: https://github.com/apache/datafusion/pull/15852#discussion_r2062983955
##
datafusion/physical-plan/src/execution_plan.rs:
##
@@ -430,6 +430,32 @@ pub trait ExecutionPlan: Debug + DisplayAs + Send + Sync {
Ok(Statistics::new
xudong963 commented on code in PR #15852:
URL: https://github.com/apache/datafusion/pull/15852#discussion_r2062952007
##
datafusion/datasource/src/file_groups.rs:
##
@@ -421,7 +421,7 @@ impl FileGroup {
}
/// Get the statistics for this group
-pub fn statistics(&
berkaysynnada commented on code in PR #15852:
URL: https://github.com/apache/datafusion/pull/15852#discussion_r2062662498
##
datafusion/datasource/src/file_groups.rs:
##
@@ -421,7 +421,7 @@ impl FileGroup {
}
/// Get the statistics for this group
-pub fn statisti
xudong963 commented on PR #15852:
URL: https://github.com/apache/datafusion/pull/15852#issuecomment-2829645057
cc @berkaysynnada PTAL, I didn't see any challenges during refactoring, the
process is smooth.
The tests are failing due to
https://github.com/apache/datafusion/issues/15689
xudong963 commented on code in PR #15852:
URL: https://github.com/apache/datafusion/pull/15852#discussion_r2059740385
##
datafusion/physical-plan/src/execution_plan.rs:
##
@@ -430,6 +430,32 @@ pub trait ExecutionPlan: Debug + DisplayAs + Send + Sync {
Ok(Statistics::new
xudong963 opened a new pull request, #15852:
URL: https://github.com/apache/datafusion/pull/15852
## Which issue does this PR close?
- Closes #.
## Rationale for this change
Follow up: https://github.com/apache/datafusion/pull/15503/
## What changes
