alamb commented on PR #14195:
URL: https://github.com/apache/datafusion/pull/14195#issuecomment-2608484699
Thanks @UBarney and @Dandandan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
alamb merged PR #14195:
URL: https://github.com/apache/datafusion/pull/14195
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on PR #14195:
URL: https://github.com/apache/datafusion/pull/14195#issuecomment-2608484584
> change: [-83.918% -83.731% -83.543%] (p = 0.00 < 0.05)
That is some sweet sweet performance
--
This is an automated message from the Apache Git Service.
To respond to the me
Dandandan closed pull request #14195: Faster reverse() string function for
ASCII-only case
URL: https://github.com/apache/datafusion/pull/14195
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
Dandandan commented on code in PR #14195:
URL: https://github.com/apache/datafusion/pull/14195#discussion_r1924121585
##
datafusion/functions/src/unicode/reverse.rs:
##
@@ -119,12 +119,21 @@ fn reverse_impl<'a, T: OffsetSizeTrait, V:
StringArrayType<'a>>(
) -> Result {
le
UBarney opened a new pull request, #14195:
URL: https://github.com/apache/datafusion/pull/14195
## Which issue does this PR close?
Closes #12445.
## Rationale for this change
See the issue.
## What changes are included in this PR?
+ If all charac
UBarney commented on code in PR #14195:
URL: https://github.com/apache/datafusion/pull/14195#discussion_r1923793794
##
datafusion/functions/src/unicode/reverse.rs:
##
@@ -119,12 +119,21 @@ fn reverse_impl<'a, T: OffsetSizeTrait, V:
StringArrayType<'a>>(
) -> Result {
let
UBarney commented on code in PR #14195:
URL: https://github.com/apache/datafusion/pull/14195#discussion_r1923792688
##
datafusion/functions/src/unicode/reverse.rs:
##
@@ -119,12 +119,21 @@ fn reverse_impl<'a, T: OffsetSizeTrait, V:
StringArrayType<'a>>(
) -> Result {
let
UBarney commented on code in PR #14195:
URL: https://github.com/apache/datafusion/pull/14195#discussion_r1923793794
##
datafusion/functions/src/unicode/reverse.rs:
##
@@ -119,12 +119,21 @@ fn reverse_impl<'a, T: OffsetSizeTrait, V:
StringArrayType<'a>>(
) -> Result {
let
UBarney commented on code in PR #14195:
URL: https://github.com/apache/datafusion/pull/14195#discussion_r1923792688
##
datafusion/functions/src/unicode/reverse.rs:
##
@@ -119,12 +119,21 @@ fn reverse_impl<'a, T: OffsetSizeTrait, V:
StringArrayType<'a>>(
) -> Result {
let
Dandandan commented on code in PR #14195:
URL: https://github.com/apache/datafusion/pull/14195#discussion_r1923260496
##
datafusion/functions/src/unicode/reverse.rs:
##
@@ -119,12 +119,21 @@ fn reverse_impl<'a, T: OffsetSizeTrait, V:
StringArrayType<'a>>(
) -> Result {
le
Dandandan commented on code in PR #14195:
URL: https://github.com/apache/datafusion/pull/14195#discussion_r1923260496
##
datafusion/functions/src/unicode/reverse.rs:
##
@@ -119,12 +119,21 @@ fn reverse_impl<'a, T: OffsetSizeTrait, V:
StringArrayType<'a>>(
) -> Result {
le
Dandandan commented on code in PR #14195:
URL: https://github.com/apache/datafusion/pull/14195#discussion_r1923260496
##
datafusion/functions/src/unicode/reverse.rs:
##
@@ -119,12 +119,21 @@ fn reverse_impl<'a, T: OffsetSizeTrait, V:
StringArrayType<'a>>(
) -> Result {
le
13 matches
Mail list logo
