Re: [PR] Expose execution time zone to UDFs [datafusion]

2025-07-03 Thread via GitHub
findepi closed pull request #16573: Expose execution time zone to UDFs URL: https://github.com/apache/datafusion/pull/16573 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Expose execution time zone to UDFs [datafusion]

2025-07-03 Thread via GitHub
findepi commented on PR #16573: URL: https://github.com/apache/datafusion/pull/16573#issuecomment-3031159421 > So it is still my opinion that copying fields from `ConfigProperties` into` ExecutionProps` one at a time will over time result in more and more "hair" (aka we'll have some subset

Re: [PR] Expose execution time zone to UDFs [datafusion]

2025-07-03 Thread via GitHub
findepi commented on code in PR #16573: URL: https://github.com/apache/datafusion/pull/16573#discussion_r2182039386 ## datafusion/core/tests/expr_api/simplification.rs: ## @@ -133,7 +133,7 @@ fn test_evaluate_with_start_time( date_time: &DateTime, ) { let execution_pr

Re: [PR] Expose execution time zone to UDFs [datafusion]

2025-07-02 Thread via GitHub
alamb commented on PR #16573: URL: https://github.com/apache/datafusion/pull/16573#issuecomment-3029236099 > It looks we didn't reach a conclusion here yet. There is "just a String" option as currently implemented in this PR. There is "a new struct passed by reference (or Arc)" option as pr

Re: [PR] Expose execution time zone to UDFs [datafusion]

2025-07-01 Thread via GitHub
findepi commented on PR #16573: URL: https://github.com/apache/datafusion/pull/16573#issuecomment-3022365302 It looks we didn't reach a conclusion here yet. There is "just a String" option as currently implemented in this PR. There is "a new struct passed by reference (or Arc)" option