Re: [PR] Encapsulate fields of `EquivalenceGroup` [datafusion]

2025-01-08 Thread via GitHub
alamb merged PR #14039: URL: https://github.com/apache/datafusion/pull/14039 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusi

Re: [PR] Encapsulate fields of `EquivalenceGroup` [datafusion]

2025-01-08 Thread via GitHub
alamb commented on PR #14039: URL: https://github.com/apache/datafusion/pull/14039#issuecomment-2577755462 Thank you for the review @berkaysynnada -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Encapsulate fields of `EquivalenceGroup` [datafusion]

2025-01-07 Thread via GitHub
alamb commented on code in PR #14039: URL: https://github.com/apache/datafusion/pull/14039#discussion_r1906004274 ## datafusion/physical-expr/src/equivalence/class.rs: ## @@ -323,11 +323,10 @@ impl Display for EquivalenceClass { } } -/// An `EquivalenceGroup` is a collec

[PR] Encapsulate fields of `EquivalenceGroup` [datafusion]

2025-01-07 Thread via GitHub
alamb opened a new pull request, #14039: URL: https://github.com/apache/datafusion/pull/14039 ## Which issue does this PR close? - Part of https://github.com/apache/datafusion/issues/13748 ## Rationale for this change As a first part of optimizing equivalence / ordering c