ozankabak commented on code in PR #15030:
URL: https://github.com/apache/datafusion/pull/15030#discussion_r1984828017
##
datafusion/physical-plan/src/execution_plan.rs:
##
@@ -260,13 +260,30 @@ pub trait ExecutionPlan: Debug + DisplayAs + Send + Sync {
/// used.
/// Th
alamb commented on PR #15030:
URL: https://github.com/apache/datafusion/pull/15030#issuecomment-2725520886
🚀 📖
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscri
alamb merged PR #15030:
URL: https://github.com/apache/datafusion/pull/15030
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
carols10cents commented on PR #15030:
URL: https://github.com/apache/datafusion/pull/15030#issuecomment-2721513303
> #15054 has been merged. @carols10cents are you willing to update this PR
again? If not I can do so too
Whoops, just updated! I also took @ozankabak's suggestion since t
alamb commented on PR #15030:
URL: https://github.com/apache/datafusion/pull/15030#issuecomment-2719030921
> I just pushed some more commits addressing some comments; there is one
TODO commit in there that I will update once #15054 has been merged in so that
I can link to the relevant part
ozankabak commented on code in PR #15030:
URL: https://github.com/apache/datafusion/pull/15030#discussion_r1987518808
##
datafusion/physical-plan/src/execution_plan.rs:
##
@@ -260,13 +260,30 @@ pub trait ExecutionPlan: Debug + DisplayAs + Send + Sync {
/// used.
/// Th
carols10cents commented on code in PR #15030:
URL: https://github.com/apache/datafusion/pull/15030#discussion_r1987354859
##
datafusion/physical-plan/src/execution_plan.rs:
##
@@ -260,13 +260,30 @@ pub trait ExecutionPlan: Debug + DisplayAs + Send + Sync {
/// used.
//
crepererum commented on code in PR #15030:
URL: https://github.com/apache/datafusion/pull/15030#discussion_r1987125412
##
datafusion/physical-plan/src/execution_plan.rs:
##
@@ -260,13 +260,30 @@ pub trait ExecutionPlan: Debug + DisplayAs + Send + Sync {
/// used.
/// T
crepererum commented on code in PR #15030:
URL: https://github.com/apache/datafusion/pull/15030#discussion_r1987422854
##
datafusion/physical-plan/src/execution_plan.rs:
##
@@ -260,13 +260,30 @@ pub trait ExecutionPlan: Debug + DisplayAs + Send + Sync {
/// used.
/// T
ozankabak commented on PR #15030:
URL: https://github.com/apache/datafusion/pull/15030#issuecomment-2704990515
Thanks for improving the docs, left my suggestions inline
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
ozankabak commented on code in PR #15030:
URL: https://github.com/apache/datafusion/pull/15030#discussion_r1985285516
##
datafusion/physical-plan/src/execution_plan.rs:
##
@@ -260,13 +260,28 @@ pub trait ExecutionPlan: Debug + DisplayAs + Send + Sync {
/// used.
/// Th
carols10cents commented on PR #15030:
URL: https://github.com/apache/datafusion/pull/15030#issuecomment-2706663774
I just pushed some more commits addressing some comments; there is one TODO
commit in there that I will update once
https://github.com/apache/datafusion/pull/15054 has been mer
carols10cents commented on code in PR #15030:
URL: https://github.com/apache/datafusion/pull/15030#discussion_r1985212925
##
datafusion/physical-plan/src/execution_plan.rs:
##
@@ -260,13 +260,30 @@ pub trait ExecutionPlan: Debug + DisplayAs + Send + Sync {
/// used.
//
carols10cents commented on code in PR #15030:
URL: https://github.com/apache/datafusion/pull/15030#discussion_r1985207813
##
datafusion/physical-plan/src/execution_plan.rs:
##
@@ -260,13 +260,30 @@ pub trait ExecutionPlan: Debug + DisplayAs + Send + Sync {
/// used.
//
carols10cents commented on code in PR #15030:
URL: https://github.com/apache/datafusion/pull/15030#discussion_r1985206291
##
datafusion/physical-plan/src/execution_plan.rs:
##
@@ -260,13 +260,30 @@ pub trait ExecutionPlan: Debug + DisplayAs + Send + Sync {
/// used.
//
berkaysynnada commented on code in PR #15030:
URL: https://github.com/apache/datafusion/pull/15030#discussion_r1984885052
##
datafusion/physical-plan/src/execution_plan.rs:
##
@@ -260,13 +260,30 @@ pub trait ExecutionPlan: Debug + DisplayAs + Send + Sync {
/// used.
//
berkaysynnada commented on code in PR #15030:
URL: https://github.com/apache/datafusion/pull/15030#discussion_r1984885052
##
datafusion/physical-plan/src/execution_plan.rs:
##
@@ -260,13 +260,30 @@ pub trait ExecutionPlan: Debug + DisplayAs + Send + Sync {
/// used.
//
crepererum commented on code in PR #15030:
URL: https://github.com/apache/datafusion/pull/15030#discussion_r1984720627
##
datafusion/physical-plan/src/execution_plan.rs:
##
@@ -260,13 +260,30 @@ pub trait ExecutionPlan: Debug + DisplayAs + Send + Sync {
/// used.
/// T
ozankabak commented on code in PR #15030:
URL: https://github.com/apache/datafusion/pull/15030#discussion_r1984082109
##
datafusion/physical-plan/src/execution_plan.rs:
##
@@ -260,13 +260,30 @@ pub trait ExecutionPlan: Debug + DisplayAs + Send + Sync {
/// used.
/// Th
ozankabak commented on code in PR #15030:
URL: https://github.com/apache/datafusion/pull/15030#discussion_r1984080469
##
datafusion/physical-plan/src/execution_plan.rs:
##
@@ -260,13 +260,30 @@ pub trait ExecutionPlan: Debug + DisplayAs + Send + Sync {
/// used.
/// Th
carols10cents commented on code in PR #15030:
URL: https://github.com/apache/datafusion/pull/15030#discussion_r1983674191
##
datafusion/physical-plan/src/execution_plan.rs:
##
@@ -260,13 +260,30 @@ pub trait ExecutionPlan: Debug + DisplayAs + Send + Sync {
/// used.
//
carols10cents commented on code in PR #15030:
URL: https://github.com/apache/datafusion/pull/15030#discussion_r1983669797
##
datafusion/physical-plan/src/execution_plan.rs:
##
@@ -260,13 +260,30 @@ pub trait ExecutionPlan: Debug + DisplayAs + Send + Sync {
/// used.
//
carols10cents commented on code in PR #15030:
URL: https://github.com/apache/datafusion/pull/15030#discussion_r1983660228
##
datafusion/physical-plan/src/execution_plan.rs:
##
@@ -260,13 +260,30 @@ pub trait ExecutionPlan: Debug + DisplayAs + Send + Sync {
/// used.
//
berkaysynnada commented on code in PR #15030:
URL: https://github.com/apache/datafusion/pull/15030#discussion_r1982848377
##
datafusion/physical-plan/src/execution_plan.rs:
##
@@ -260,13 +260,30 @@ pub trait ExecutionPlan: Debug + DisplayAs + Send + Sync {
/// used.
//
berkaysynnada commented on code in PR #15030:
URL: https://github.com/apache/datafusion/pull/15030#discussion_r1982854173
##
datafusion/physical-plan/src/execution_plan.rs:
##
@@ -260,13 +260,30 @@ pub trait ExecutionPlan: Debug + DisplayAs + Send + Sync {
/// used.
//
berkaysynnada commented on code in PR #15030:
URL: https://github.com/apache/datafusion/pull/15030#discussion_r1982848377
##
datafusion/physical-plan/src/execution_plan.rs:
##
@@ -260,13 +260,30 @@ pub trait ExecutionPlan: Debug + DisplayAs + Send + Sync {
/// used.
//
alamb commented on code in PR #15030:
URL: https://github.com/apache/datafusion/pull/15030#discussion_r1982248397
##
datafusion/physical-plan/src/execution_plan.rs:
##
@@ -260,13 +260,30 @@ pub trait ExecutionPlan: Debug + DisplayAs + Send + Sync {
/// used.
/// Thus,
carols10cents opened a new pull request, #15030:
URL: https://github.com/apache/datafusion/pull/15030
To start a policy of the behavior physical operator streams should have and
drive improvements in this area to allow for timely cancellation.
I'm very open to any wording changes and
28 matches
Mail list logo
