Re: [PR] Consolidate statistics merging code [datafusion]

2025-04-10 Thread via GitHub
xudong963 commented on PR #15645: URL: https://github.com/apache/datafusion/pull/15645#issuecomment-2789458536 Just noticed the PR. FYI, I've reviewed it in the PR: https://github.com/xudong963/arrow-datafusion/pull/5 -- This is an automated message from the Apache Git Service. To

Re: [PR] Consolidate statistics merging code [datafusion]

2025-04-09 Thread via GitHub
alamb closed pull request #15645: Consolidate statistics merging code URL: https://github.com/apache/datafusion/pull/15645 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] Consolidate statistics merging code [datafusion]

2025-04-09 Thread via GitHub
alamb commented on PR #15645: URL: https://github.com/apache/datafusion/pull/15645#issuecomment-2790368284 Thanks @xudong963 -- I will work on this in a follow on PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] Consolidate statistics merging code [datafusion]

2025-04-08 Thread via GitHub
alamb commented on code in PR #15645: URL: https://github.com/apache/datafusion/pull/15645#discussion_r2034038864 ## datafusion/common/src/stats.rs: ## @@ -433,6 +480,79 @@ fn check_num_rows(value: Option, is_exact: bool) -> Precision { } } +pub fn add_row_stats( Revie

Re: [PR] Consolidate statistics merging code [datafusion]

2025-04-08 Thread via GitHub
alamb commented on code in PR #15645: URL: https://github.com/apache/datafusion/pull/15645#discussion_r2034037213 ## datafusion/common/src/stats.rs: ## @@ -414,6 +414,53 @@ impl Statistics { self.total_byte_size = Precision::Absent; Ok(self) } + +/// S

Re: [PR] Consolidate statistics merging code [datafusion]

2025-04-08 Thread via GitHub
alamb commented on code in PR #15645: URL: https://github.com/apache/datafusion/pull/15645#discussion_r2034037213 ## datafusion/common/src/stats.rs: ## @@ -414,6 +414,53 @@ impl Statistics { self.total_byte_size = Precision::Absent; Ok(self) } + +/// S

[PR] Consolidate statistics merging code [datafusion]

2025-04-08 Thread via GitHub
alamb opened a new pull request, #15645: URL: https://github.com/apache/datafusion/pull/15645 ## Which issue does this PR close? - Related to https://github.com/apache/datafusion/pull/15503 - Part of https://github.com/apache/datafusion/issues/8229 - Part of https://github.com/ap