Weijun-H commented on PR #15104:
URL: https://github.com/apache/datafusion/pull/15104#issuecomment-2716173344
Thanks @zhuqi-lucas and @alamb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
Weijun-H merged PR #15104:
URL: https://github.com/apache/datafusion/pull/15104
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
zhuqi-lucas commented on code in PR #15104:
URL: https://github.com/apache/datafusion/pull/15104#discussion_r1989511048
##
datafusion/common/src/config.rs:
##
@@ -252,6 +252,11 @@ config_namespace! {
/// string length and thus DataFusion can not enforce such limits.
Weijun-H commented on code in PR #15104:
URL: https://github.com/apache/datafusion/pull/15104#discussion_r1989354378
##
datafusion/common/src/config.rs:
##
@@ -252,6 +252,11 @@ config_namespace! {
/// string length and thus DataFusion can not enforce such limits.
zhuqi-lucas commented on code in PR #15104:
URL: https://github.com/apache/datafusion/pull/15104#discussion_r1986337572
##
datafusion/core/tests/dataframe/mod.rs:
##
@@ -5673,3 +5673,43 @@ async fn test_fill_null_all_columns() -> Result<()> {
assert_batches_sorted_eq!(expec
zhuqi-lucas commented on code in PR #15104:
URL: https://github.com/apache/datafusion/pull/15104#discussion_r1986337689
##
datafusion/common/src/config.rs:
##
@@ -252,6 +252,11 @@ config_namespace! {
/// string length and thus DataFusion can not enforce such limits.
zhuqi-lucas commented on PR #15104:
URL: https://github.com/apache/datafusion/pull/15104#issuecomment-2708885055
> Thanks @zhuqi-lucas ! This looks great. I have a few comments. Let me know
what you think
Thank you @alamb for review, great suggestions. Addressed in latest PR.
--
Th
alamb commented on code in PR #15104:
URL: https://github.com/apache/datafusion/pull/15104#discussion_r1986315228
##
datafusion/core/tests/dataframe/mod.rs:
##
@@ -5673,3 +5673,43 @@ async fn test_fill_null_all_columns() -> Result<()> {
assert_batches_sorted_eq!(expected, &
zhuqi-lucas opened a new pull request, #15104:
URL: https://github.com/apache/datafusion/pull/15104
## Which issue does this PR close?
This is the first step of our incremental work for this issue:
https://github.com/apache/datafusion/issues/15096
## Rationale for this ch
