mbutrovich merged PR #1874:
URL: https://github.com/apache/datafusion-comet/pull/1874
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...
trompa commented on code in PR #1874:
URL: https://github.com/apache/datafusion-comet/pull/1874#discussion_r2152871276
##
native/core/src/execution/planner.rs:
##
@@ -460,22 +459,40 @@ impl PhysicalPlanner {
)))
}
ExprStruct::Hour(expr)
mbutrovich commented on code in PR #1874:
URL: https://github.com/apache/datafusion-comet/pull/1874#discussion_r2152838275
##
native/core/src/execution/planner.rs:
##
@@ -460,22 +459,40 @@ impl PhysicalPlanner {
)))
}
ExprStruct::Hour(e
trompa commented on PR #1874:
URL:
https://github.com/apache/datafusion-comet/pull/1874#issuecomment-2979529062
@mbutrovich
test checking fold on JVM added, rebased from main.
I think it is ready for a review
--
This is an automated message from the Apache Git Service.
To r
trompa commented on PR #1874:
URL:
https://github.com/apache/datafusion-comet/pull/1874#issuecomment-2973588238
code is now using a macro to generate the 3 hour, minute and second
functions.
new spark test to check literals are folded on jvm side
--
This is an automated message from t
