Re: [PR] Cancellation benchmark [datafusion]

2025-02-26 Thread via GitHub
alamb merged PR #14818: URL: https://github.com/apache/datafusion/pull/14818 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusi

Re: [PR] Cancellation benchmark [datafusion]

2025-02-26 Thread via GitHub
alamb commented on PR #14818: URL: https://github.com/apache/datafusion/pull/14818#issuecomment-2685749538 Thanks again @carols10cents -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] Cancellation benchmark [datafusion]

2025-02-26 Thread via GitHub
alamb commented on code in PR #14818: URL: https://github.com/apache/datafusion/pull/14818#discussion_r1972019358 ## benchmarks/src/cancellation.rs: ## @@ -0,0 +1,329 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. S

Re: [PR] Cancellation benchmark [datafusion]

2025-02-24 Thread via GitHub
carols10cents commented on PR #14818: URL: https://github.com/apache/datafusion/pull/14818#issuecomment-2678695543 > > Let's see if this works too > > /benchmark > > It doesn't sadly -- we removed this due to potential security concerns Ok-- I'll remove the documentation

Re: [PR] Cancellation benchmark [datafusion]

2025-02-24 Thread via GitHub
alamb commented on PR #14818: URL: https://github.com/apache/datafusion/pull/14818#issuecomment-2678595248 > Let's see if this works too > > /benchmark It doesn't sadly -- we removed this due to potential security concerns -- This is an automated message from the Apache G

Re: [PR] Cancellation benchmark [datafusion]

2025-02-21 Thread via GitHub
carols10cents commented on PR #14818: URL: https://github.com/apache/datafusion/pull/14818#issuecomment-2675566618 Let's see if this works too /benchmark -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[PR] Cancellation benchmark [datafusion]

2025-02-21 Thread via GitHub
carols10cents opened a new pull request, #14818: URL: https://github.com/apache/datafusion/pull/14818 ## Which issue does this PR close? Connects to #14036 (does not close it). ## Rationale for this change The behavior observed in #14036 was hard to reproduce and quantify