Re: [PR] ArraySort: support structs [datafusion]

2025-04-05 Thread via GitHub
alamb merged PR #15527: URL: https://github.com/apache/datafusion/pull/15527 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusi

Re: [PR] ArraySort: support structs [datafusion]

2025-04-02 Thread via GitHub
alamb closed pull request #15527: ArraySort: support structs URL: https://github.com/apache/datafusion/pull/15527 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [PR] ArraySort: support structs [datafusion]

2025-04-02 Thread via GitHub
alamb commented on PR #15527: URL: https://github.com/apache/datafusion/pull/15527#issuecomment-2773621630 Thanks again @cht42 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] ArraySort: support structs [datafusion]

2025-04-01 Thread via GitHub
alamb commented on PR #15527: URL: https://github.com/apache/datafusion/pull/15527#issuecomment-2770318099 Close/reopen PR to retrigger CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] ArraySort: support structs [datafusion]

2025-04-01 Thread via GitHub
alamb commented on code in PR #15527: URL: https://github.com/apache/datafusion/pull/15527#discussion_r2023199823 ## datafusion/functions-nested/src/sort.rs: ## @@ -207,9 +208,21 @@ pub fn array_sort_inner(args: &[ArrayRef]) -> Result { valid.append_null();

Re: [PR] ArraySort: support structs [datafusion]

2025-04-01 Thread via GitHub
alamb commented on code in PR #15527: URL: https://github.com/apache/datafusion/pull/15527#discussion_r2023199085 ## datafusion/functions-nested/src/sort.rs: ## @@ -207,9 +208,21 @@ pub fn array_sort_inner(args: &[ArrayRef]) -> Result { valid.append_null();

Re: [PR] ArraySort: support structs [datafusion]

2025-04-01 Thread via GitHub
cht42 commented on code in PR #15527: URL: https://github.com/apache/datafusion/pull/15527#discussion_r2023172721 ## datafusion/functions-nested/src/sort.rs: ## @@ -207,9 +208,21 @@ pub fn array_sort_inner(args: &[ArrayRef]) -> Result { valid.append_null();

Re: [PR] ArraySort: support structs [datafusion]

2025-04-01 Thread via GitHub
cht42 commented on code in PR #15527: URL: https://github.com/apache/datafusion/pull/15527#discussion_r2023164133 ## datafusion/functions-nested/src/sort.rs: ## @@ -207,9 +208,21 @@ pub fn array_sort_inner(args: &[ArrayRef]) -> Result { valid.append_null();

Re: [PR] ArraySort: support structs [datafusion]

2025-04-01 Thread via GitHub
alamb commented on code in PR #15527: URL: https://github.com/apache/datafusion/pull/15527#discussion_r2023103674 ## datafusion/functions-nested/src/sort.rs: ## @@ -207,9 +208,21 @@ pub fn array_sort_inner(args: &[ArrayRef]) -> Result { valid.append_null();

[PR] ArraySort: support structs [datafusion]

2025-04-01 Thread via GitHub
cht42 opened a new pull request, #15527: URL: https://github.com/apache/datafusion/pull/15527 ## Which issue does this PR close? - Closes #15526 ## Rationale for this change ## What changes are included in this PR? ## Are these changes teste