Re: [PR] Apply take_function_args [datafusion]

2025-02-06 Thread via GitHub
lgingerich commented on PR #14525: URL: https://github.com/apache/datafusion/pull/14525#issuecomment-2641605649 > I think you would have to move it somwehere like `datafusion_common` Sounds good, I should get to that this weekend and then I'll apply `take_function_args()` in other cra

Re: [PR] Apply take_function_args [datafusion]

2025-02-06 Thread via GitHub
alamb commented on PR #14525: URL: https://github.com/apache/datafusion/pull/14525#issuecomment-2640906182 > @findepi Is there a good way to use `take_function_args()` outside of the `functions` crate? I think you would have to move it somwehere like `datafusion_common` --

Re: [PR] Apply take_function_args [datafusion]

2025-02-06 Thread via GitHub
lgingerich commented on PR #14525: URL: https://github.com/apache/datafusion/pull/14525#issuecomment-2640124923 @findepi Is there a good way to use `take_function_args()` outside of the `functions` crate? -- This is an automated message from the Apache Git Service. To respond to the messa

[PR] Apply take_function_args [datafusion]

2025-02-06 Thread via GitHub
lgingerich opened a new pull request, #14525: URL: https://github.com/apache/datafusion/pull/14525 ## Which issue does this PR close? - Closes #14516. ## What changes are included in this PR? Refactor function argument count validation for the following crates: `functions`.