2010YOUY01 merged PR #14498:
URL: https://github.com/apache/datafusion/pull/14498
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dat
2010YOUY01 commented on PR #14498:
URL: https://github.com/apache/datafusion/pull/14498#issuecomment-2644818671
> My benchmark results show no change in Q22 (but also clearly the data is
quite noisy 🤔 )
>
> ```
>
> Benchmark tpch_sf1.json
> --
alamb commented on PR #14498:
URL: https://github.com/apache/datafusion/pull/14498#issuecomment-2644084648
My benchmark results show no change in Q22 (but also clearly the data is
quite noisy 🤔 )
```
Benchmark tpch_sf1.json
┏━━
alamb commented on PR #14498:
URL: https://github.com/apache/datafusion/pull/14498#issuecomment-2643744227
Thank you @Kev1n8 and @2010YOUY01 -- I am running some benchmarks on this
PR to see if it makes any difference
--
This is an automated message from the Apache Git Service.
To respon
Kev1n8 commented on PR #14498:
URL: https://github.com/apache/datafusion/pull/14498#issuecomment-2642144319
> Could you resolve the conflict?
Sure. Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
2010YOUY01 commented on PR #14498:
URL: https://github.com/apache/datafusion/pull/14498#issuecomment-2641979566
Thank you, it looks good to me.
Could you resolve the conflict?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
Kev1n8 opened a new pull request, #14498:
URL: https://github.com/apache/datafusion/pull/14498
## Which issue does this PR close?
Closes #12338
## Rationale for this change
Generate `StringViewArray` whatever input type is for efficiency.
## What change
