Re: [PR] Allow constructing ScalarUDF from shared implementation [datafusion]

2025-02-07 Thread via GitHub
findepi commented on code in PR #14541: URL: https://github.com/apache/datafusion/pull/14541#discussion_r1947197039 ## datafusion/expr/src/udaf.rs: ## @@ -119,9 +119,12 @@ impl AggregateUDF { where F: AggregateUDFImpl + 'static, { -Self { -

Re: [PR] Allow constructing ScalarUDF from shared implementation [datafusion]

2025-02-07 Thread via GitHub
findepi merged PR #14541: URL: https://github.com/apache/datafusion/pull/14541 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafu

Re: [PR] Allow constructing ScalarUDF from shared implementation [datafusion]

2025-02-07 Thread via GitHub
findepi commented on code in PR #14541: URL: https://github.com/apache/datafusion/pull/14541#discussion_r1947197259 ## datafusion/expr/src/udaf.rs: ## @@ -119,9 +119,12 @@ impl AggregateUDF { where F: AggregateUDFImpl + 'static, { -Self { -

Re: [PR] Allow constructing ScalarUDF from shared implementation [datafusion]

2025-02-07 Thread via GitHub
alamb commented on code in PR #14541: URL: https://github.com/apache/datafusion/pull/14541#discussion_r1946990866 ## datafusion/expr/src/udaf.rs: ## @@ -119,9 +119,12 @@ impl AggregateUDF { where F: AggregateUDFImpl + 'static, { -Self { -in

Re: [PR] Allow constructing ScalarUDF from shared implementation [datafusion]

2025-02-07 Thread via GitHub
alamb commented on code in PR #14541: URL: https://github.com/apache/datafusion/pull/14541#discussion_r1946983077 ## datafusion/expr/src/udaf.rs: ## @@ -119,9 +119,12 @@ impl AggregateUDF { where F: AggregateUDFImpl + 'static, { -Self { -in

Re: [PR] Allow constructing ScalarUDF from shared implementation [datafusion]

2025-02-07 Thread via GitHub
findepi commented on code in PR #14541: URL: https://github.com/apache/datafusion/pull/14541#discussion_r1946891887 ## datafusion/expr/src/udaf.rs: ## @@ -119,9 +119,12 @@ impl AggregateUDF { where F: AggregateUDFImpl + 'static, { -Self { -

Re: [PR] Allow constructing ScalarUDF from shared implementation [datafusion]

2025-02-07 Thread via GitHub
alamb commented on code in PR #14541: URL: https://github.com/apache/datafusion/pull/14541#discussion_r1946707537 ## datafusion/expr/src/udaf.rs: ## @@ -119,9 +119,12 @@ impl AggregateUDF { where F: AggregateUDFImpl + 'static, { -Self { -in

Re: [PR] Allow constructing ScalarUDF from shared implementation [datafusion]

2025-02-07 Thread via GitHub
alamb commented on code in PR #14541: URL: https://github.com/apache/datafusion/pull/14541#discussion_r1946707537 ## datafusion/expr/src/udaf.rs: ## @@ -119,9 +119,12 @@ impl AggregateUDF { where F: AggregateUDFImpl + 'static, { -Self { -in

[PR] Allow constructing ScalarUDF from shared implementation [datafusion]

2025-02-07 Thread via GitHub
findepi opened a new pull request, #14541: URL: https://github.com/apache/datafusion/pull/14541 When composing or decorating functions, it's useful to operate on Impl trait objects (dyn ScalarUDFImpl) instead of the Expr-level adapter (ScalarUDF). However, before the change, it was impossib