alamb commented on PR #15980:
URL: https://github.com/apache/datafusion/pull/15980#issuecomment-2936183106
Marking as draft as I think this PR is no longer waiting on feedback and I
am trying to make it easier to find PRs in need of review. Please mark it as
ready for review when it is read
alamb commented on code in PR #15980:
URL: https://github.com/apache/datafusion/pull/15980#discussion_r2115997415
##
datafusion/expr/src/logical_plan/plan.rs:
##
@@ -1494,6 +1494,14 @@ impl LogicalPlan {
let mut param_types: HashMap> =
HashMap::new();
self.a
kczimm commented on code in PR #15980:
URL: https://github.com/apache/datafusion/pull/15980#discussion_r2114359645
##
datafusion/expr/src/logical_plan/plan.rs:
##
@@ -1494,6 +1494,14 @@ impl LogicalPlan {
let mut param_types: HashMap> =
HashMap::new();
self.
alamb commented on code in PR #15980:
URL: https://github.com/apache/datafusion/pull/15980#discussion_r2112276143
##
datafusion/expr/src/logical_plan/plan.rs:
##
@@ -1494,6 +1494,14 @@ impl LogicalPlan {
let mut param_types: HashMap> =
HashMap::new();
self.a
alamb commented on code in PR #15980:
URL: https://github.com/apache/datafusion/pull/15980#discussion_r2082330048
##
datafusion/expr/src/logical_plan/plan.rs:
##
@@ -1494,6 +1494,14 @@ impl LogicalPlan {
let mut param_types: HashMap> =
HashMap::new();
self.a
kczimm commented on code in PR #15980:
URL: https://github.com/apache/datafusion/pull/15980#discussion_r2080118522
##
datafusion/expr/src/logical_plan/plan.rs:
##
@@ -1494,6 +1494,14 @@ impl LogicalPlan {
let mut param_types: HashMap> =
HashMap::new();
self.
kczimm commented on code in PR #15980:
URL: https://github.com/apache/datafusion/pull/15980#discussion_r2080123467
##
datafusion/expr/src/logical_plan/plan.rs:
##
@@ -1507,6 +1515,9 @@ impl LogicalPlan {
(_, Some(dt)) => {
kczimm commented on code in PR #15980:
URL: https://github.com/apache/datafusion/pull/15980#discussion_r2080118522
##
datafusion/expr/src/logical_plan/plan.rs:
##
@@ -1494,6 +1494,14 @@ impl LogicalPlan {
let mut param_types: HashMap> =
HashMap::new();
self.
kczimm commented on code in PR #15980:
URL: https://github.com/apache/datafusion/pull/15980#discussion_r2080056995
##
datafusion/expr/src/expr.rs:
##
@@ -1775,6 +1775,27 @@ impl Expr {
| Expr::SimilarTo(Like { expr, pattern, .. }) => {
rewri
alamb commented on code in PR #15980:
URL: https://github.com/apache/datafusion/pull/15980#discussion_r2078420969
##
datafusion/expr/src/expr.rs:
##
@@ -1775,6 +1775,27 @@ impl Expr {
| Expr::SimilarTo(Like { expr, pattern, .. }) => {
rewrit
kczimm opened a new pull request, #15980:
URL: https://github.com/apache/datafusion/pull/15980
## Which issue does this PR close?
- Closes https://github.com/apache/datafusion/issues/15978
- Closes https://github.com/apache/datafusion/issues/15979
## Rationale for thi
11 matches
Mail list logo
