alamb merged PR #14687:
URL: https://github.com/apache/datafusion/pull/14687
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on PR #14687:
URL: https://github.com/apache/datafusion/pull/14687#issuecomment-2843915892
Thank you @Omega359 and @gstvg for your patience
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
alamb commented on PR #14687:
URL: https://github.com/apache/datafusion/pull/14687#issuecomment-2840392253
> LGTM. I think I'd like to see a test with multiple columns but the logic
looks solid to me. I believe the use of unsafe is indeed ok given the
conditions outlined.
Thanks agai
alamb commented on code in PR #14687:
URL: https://github.com/apache/datafusion/pull/14687#discussion_r2067521368
##
datafusion/sqllogictest/test_files/union_function.slt:
##
@@ -45,3 +49,19 @@ select union_extract(union_column, 1) from union_table;
query error DataFusion err
alamb commented on code in PR #14687:
URL: https://github.com/apache/datafusion/pull/14687#discussion_r2067520961
##
datafusion/sqllogictest/test_files/union_function.slt:
##
@@ -23,7 +26,8 @@ query ?I
select union_column, union_extract(union_column, 'int') from union_table;
-
Omega359 commented on PR #14687:
URL: https://github.com/apache/datafusion/pull/14687#issuecomment-2840240489
LGTM. I think I'd like to see a test with multiple columns but the logic
looks solid to me. I believe the use of unsafe is indeed ok given the
conditions outlined.
--
This is an
Omega359 commented on PR #14687:
URL: https://github.com/apache/datafusion/pull/14687#issuecomment-2838977501
I'll review it today @alamb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
Omega359 commented on PR #14687:
URL: https://github.com/apache/datafusion/pull/14687#issuecomment-2821576525
@alamb, thoughts on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
github-actions[bot] commented on PR #14687:
URL: https://github.com/apache/datafusion/pull/14687#issuecomment-2819872276
Thank you for your contribution. Unfortunately, this pull request is stale
because it has been open 60 days with no activity. Please remove the stale
label or comment or
Omega359 commented on PR #14687:
URL: https://github.com/apache/datafusion/pull/14687#issuecomment-2668798412
> Yeah I agree. I think we should file a "discussion" type ticket to have
this discussion. I can file one at some point later (I am low on time this
week) or if you can that would b
alamb commented on PR #14687:
URL: https://github.com/apache/datafusion/pull/14687#issuecomment-2668519587
> @alamb - here is another function coming in (xxhash, regexp_extract (both
versions of it), array_min/array_max functions) where it is not clear what
should be accepted and what shoul
Omega359 commented on PR #14687:
URL: https://github.com/apache/datafusion/pull/14687#issuecomment-264841
@alamb - here is another function coming in (xxhash, regexp_extract (both
versions of it), array_min/array_max functions) where it is not clear what
should be accepted and what shou
gstvg commented on code in PR #14687:
URL: https://github.com/apache/datafusion/pull/14687#discussion_r1958697188
##
datafusion/functions/src/core/union_tag.rs:
##
@@ -0,0 +1,223 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license ag
gstvg commented on code in PR #14687:
URL: https://github.com/apache/datafusion/pull/14687#discussion_r1958697188
##
datafusion/functions/src/core/union_tag.rs:
##
@@ -0,0 +1,223 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license ag
gstvg opened a new pull request, #14687:
URL: https://github.com/apache/datafusion/pull/14687
## Which issue does this PR close?
- Closes #11080
## Rationale for this change
Retrieve the name of the currently selected field on a union, as there's no
way to do it today
15 matches
Mail list logo
