alamb commented on code in PR #16686:
URL: https://github.com/apache/datafusion/pull/16686#discussion_r2193493034
##
datafusion/core/tests/physical_optimizer/filter_pushdown/mod.rs:
##
@@ -289,7 +289,7 @@ fn test_no_pushdown_through_aggregates() {
Ok:
- Filte
alamb merged PR #16686:
URL: https://github.com/apache/datafusion/pull/16686
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
liamzwbao commented on code in PR #16686:
URL: https://github.com/apache/datafusion/pull/16686#discussion_r2188415579
##
datafusion/datasource/src/source.rs:
##
@@ -325,6 +328,9 @@ impl ExecutionPlan for DataSourceExec {
new_node.data_source = data_source;
xudong963 commented on PR #16686:
URL: https://github.com/apache/datafusion/pull/16686#issuecomment-3041900763
I'll verify the PR in our fork tomorrow, thanks @liamzwbao
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
xudong963 commented on code in PR #16686:
URL: https://github.com/apache/datafusion/pull/16686#discussion_r2188374284
##
datafusion/datasource/src/source.rs:
##
@@ -372,6 +378,20 @@ impl DataSourceExec {
self
}
+/// Add filters' equivalence info
+fn add_f
liamzwbao commented on code in PR #16686:
URL: https://github.com/apache/datafusion/pull/16686#discussion_r2188365661
##
datafusion/sqllogictest/test_files/parquet_filter_pushdown.slt:
##
@@ -239,6 +349,23 @@ physical_plan
05)RepartitionExec: partitioning=RoundRobinBatc
adriangb commented on code in PR #16686:
URL: https://github.com/apache/datafusion/pull/16686#discussion_r2187232804
##
datafusion/datasource/src/source.rs:
##
@@ -325,6 +328,9 @@ impl ExecutionPlan for DataSourceExec {
new_node.data_source = data_source;
alamb commented on PR #16686:
URL: https://github.com/apache/datafusion/pull/16686#issuecomment-3038695163
Thank you @liamzwbao
@xudong963 or @adriangb do you have time to review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please
liamzwbao commented on code in PR #16686:
URL: https://github.com/apache/datafusion/pull/16686#discussion_r2186078102
##
datafusion/core/tests/physical_optimizer/filter_pushdown/mod.rs:
##
@@ -289,7 +289,7 @@ fn test_no_pushdown_through_aggregates() {
Ok:
- F
liamzwbao opened a new pull request, #16686:
URL: https://github.com/apache/datafusion/pull/16686
## Which issue does this PR close?
- Closes #16563.
## Rationale for this change
Add the missing equivalence info so that optimizer can pick it up when
pruni
10 matches
Mail list logo
