Omega359 commented on PR #13403:
URL: https://github.com/apache/datafusion/pull/13403#issuecomment-2494565464
> I agree -- there is no guideline that I know of. Any chance you would be
willing to propose one?
I'll have to think about it tbh @alamb. Part of that is to know the cost to
alamb merged PR #13403:
URL: https://github.com/apache/datafusion/pull/13403
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on PR #13403:
URL: https://github.com/apache/datafusion/pull/13403#issuecomment-2492398784
Let's go with this and iterate on improvements going forward
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
alamb commented on PR #13403:
URL: https://github.com/apache/datafusion/pull/13403#issuecomment-2491701015
> That is a very good point @alamb and one that I don't have an answer to.
Is there any guidelines anywhere as to what should be covered and what
shouldn't? From my reading of function
Omega359 commented on PR #13403:
URL: https://github.com/apache/datafusion/pull/13403#issuecomment-2491314326
> I do wonder if we really need this level of specialization, but I also
think since this is clearly better than what is on main we can/should merge it
in
That is a very good
Omega359 commented on code in PR #13403:
URL: https://github.com/apache/datafusion/pull/13403#discussion_r1851135533
##
datafusion/functions-nested/src/string.rs:
##
@@ -524,63 +687,90 @@ pub fn string_to_array_inner(args:
&[ArrayRef]) -> Result {
s
alamb commented on code in PR #13403:
URL: https://github.com/apache/datafusion/pull/13403#discussion_r1851052692
##
datafusion/functions-nested/src/string.rs:
##
@@ -524,63 +687,90 @@ pub fn string_to_array_inner(args:
&[ArrayRef]) -> Result {
stri
Omega359 commented on PR #13403:
URL: https://github.com/apache/datafusion/pull/13403#issuecomment-2488651850
Ready for review again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
alamb commented on PR #13403:
URL: https://github.com/apache/datafusion/pull/13403#issuecomment-2484052694
Converting to draft while @Omega359 makes the changes described in
https://github.com/apache/datafusion/pull/13403#issuecomment-2483441618
--
This is an automated message from the A
Omega359 commented on PR #13403:
URL: https://github.com/apache/datafusion/pull/13403#issuecomment-2483441618
Do not merge - this PR does not properly handle largeutf8 and I want to try
to refactor the code to reduce the # of lines of code
--
This is an automated message from the Apache G
Omega359 commented on code in PR #13403:
URL: https://github.com/apache/datafusion/pull/13403#discussion_r1845190135
##
datafusion/functions-nested/src/string.rs:
##
@@ -251,20 +254,21 @@ impl ScalarUDFImpl for StringToArray {
Utf8 | LargeUtf8 => {
findepi commented on code in PR #13403:
URL: https://github.com/apache/datafusion/pull/13403#discussion_r1845182679
##
datafusion/functions-nested/src/string.rs:
##
@@ -251,20 +254,21 @@ impl ScalarUDFImpl for StringToArray {
Utf8 | LargeUtf8 => {
L
findepi commented on code in PR #13403:
URL: https://github.com/apache/datafusion/pull/13403#discussion_r1845181616
##
datafusion/functions-nested/src/string.rs:
##
@@ -88,6 +90,7 @@ macro_rules! call_array_function {
($DATATYPE:expr, $INCLUDE_LIST:expr) => {{
matc
Omega359 commented on code in PR #13403:
URL: https://github.com/apache/datafusion/pull/13403#discussion_r1845164042
##
datafusion/functions-nested/src/string.rs:
##
@@ -88,6 +90,7 @@ macro_rules! call_array_function {
($DATATYPE:expr, $INCLUDE_LIST:expr) => {{
mat
Omega359 commented on code in PR #13403:
URL: https://github.com/apache/datafusion/pull/13403#discussion_r1845170064
##
datafusion/functions-nested/src/string.rs:
##
@@ -251,20 +254,21 @@ impl ScalarUDFImpl for StringToArray {
Utf8 | LargeUtf8 => {
findepi commented on code in PR #13403:
URL: https://github.com/apache/datafusion/pull/13403#discussion_r1845150639
##
datafusion/functions-nested/src/string.rs:
##
@@ -251,20 +254,21 @@ impl ScalarUDFImpl for StringToArray {
Utf8 | LargeUtf8 => {
L
Omega359 commented on code in PR #13403:
URL: https://github.com/apache/datafusion/pull/13403#discussion_r1842448505
##
datafusion/functions-nested/src/string.rs:
##
@@ -251,20 +254,21 @@ impl ScalarUDFImpl for StringToArray {
Utf8 | LargeUtf8 => {
Omega359 commented on code in PR #13403:
URL: https://github.com/apache/datafusion/pull/13403#discussion_r1842448505
##
datafusion/functions-nested/src/string.rs:
##
@@ -251,20 +254,21 @@ impl ScalarUDFImpl for StringToArray {
Utf8 | LargeUtf8 => {
jayzhan211 commented on code in PR #13403:
URL: https://github.com/apache/datafusion/pull/13403#discussion_r1841884150
##
datafusion/functions-nested/src/string.rs:
##
@@ -251,20 +254,21 @@ impl ScalarUDFImpl for StringToArray {
Utf8 | LargeUtf8 => {
Omega359 opened a new pull request, #13403:
URL: https://github.com/apache/datafusion/pull/13403
## Which issue does this PR close?
Closes #13383
## Rationale for this change
Completing support for Utf8View in all functions.
## What changes are included in this PR?
20 matches
Mail list logo
