gabotechs commented on PR #16793:
URL: https://github.com/apache/datafusion/pull/16793#issuecomment-3125658277
> or is
https://github.com/apache/datafusion/pull/16793#pullrequestreview-3032328344
suggesting changes for a future PR?
I think those changes will need to happen either in
alamb commented on PR #16793:
URL: https://github.com/apache/datafusion/pull/16793#issuecomment-3120123644
I am not quite sure what the next steps for this PR are. @gabotechs do you
think there need to be changes, or is
https://github.com/apache/datafusion/pull/16793#pullrequestreview-30323
LiaCastaneda commented on code in PR #16793:
URL: https://github.com/apache/datafusion/pull/16793#discussion_r2215099809
##
datafusion/substrait/src/logical_plan/producer/types.rs:
##
@@ -96,7 +96,15 @@ pub(crate) fn to_substrait_type(
nullability,
jatin510 commented on PR #16793:
URL: https://github.com/apache/datafusion/pull/16793#issuecomment-3084767084
made some changes @gabotechs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
alamb commented on PR #16793:
URL: https://github.com/apache/datafusion/pull/16793#issuecomment-3075381830
Thank you @jatin510
@gabotechs or @LiaCastaneda would you have time to review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message,
jatin510 opened a new pull request, #16793:
URL: https://github.com/apache/datafusion/pull/16793
## Which issue does this PR close?
- Closes https://github.com/apache/datafusion/issues/16298.
## Rationale for this change
## What changes are included in thi
