Re: [PR] Add sqlite test files into sqllogictests [datafusion]

2024-12-29 Thread via GitHub
alamb commented on code in PR #13936: URL: https://github.com/apache/datafusion/pull/13936#discussion_r1899135647 ## datafusion/sqllogictest/README.md: ## @@ -160,7 +161,7 @@ cargo test --test sqllogictests -- information Test files that start with prefix `pg_compat_` verify co

Re: [PR] Add sqlite test files into sqllogictests [datafusion]

2024-12-28 Thread via GitHub
Omega359 commented on PR #13936: URL: https://github.com/apache/datafusion/pull/13936#issuecomment-2564545013 Related: https://github.com/apache/datafusion-testing/pull/2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Add sqlite test files into sqllogictests [datafusion]

2024-12-28 Thread via GitHub
Omega359 closed pull request #13935: Add sqlite test files into sqllogictests URL: https://github.com/apache/datafusion/pull/13935 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[PR] Add sqlite test files into sqllogictests [datafusion]

2024-12-28 Thread via GitHub
Omega359 opened a new pull request, #13936: URL: https://github.com/apache/datafusion/pull/13936 ## Which issue does this PR close? Closes #13812 ## Rationale for this change Add most of the sqlite test suite to Datafusion sqllogictests. Note: **THESE TESTS DO NO

[PR] Add sqlite test files into sqllogictests [datafusion]

2024-12-28 Thread via GitHub
Omega359 opened a new pull request, #13935: URL: https://github.com/apache/datafusion/pull/13935 ## Which issue does this PR close? Closes #13812 ## Rationale for this change Add most of the sqlite test suite to Datafusion sqllogictests. Note: **THESE TESTS DO NO

Re: [PR] Add sqlite test files into sqllogictests [datafusion]

2024-12-28 Thread via GitHub
Omega359 commented on PR #13932: URL: https://github.com/apache/datafusion/pull/13932#issuecomment-2564519315 Closing this PR to create another using a clean branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Add sqlite test files into sqllogictests [datafusion]

2024-12-28 Thread via GitHub
Omega359 closed pull request #13932: Add sqlite test files into sqllogictests URL: https://github.com/apache/datafusion/pull/13932 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] Add sqlite test files into sqllogictests [datafusion]

2024-12-27 Thread via GitHub
Omega359 commented on PR #13932: URL: https://github.com/apache/datafusion/pull/13932#issuecomment-2564134284 The large file check is failing because this branch used to have large files in it before they were move to the datafusion-testing repo. I am pretty sure those will be dropped as pa

[PR] Add sqlite test files into sqllogictests [datafusion]

2024-12-27 Thread via GitHub
Omega359 opened a new pull request, #13932: URL: https://github.com/apache/datafusion/pull/13932 ## Which issue does this PR close? Closes #13812 ## Rationale for this change Add most of the sqlite test suite to Datafusion sqllogictests. Note: **THESE TESTS DO NO