Omega359 commented on PR #14095:
URL: https://github.com/apache/datafusion/pull/14095#issuecomment-2783525509
I just built main and tested the sql from #14091 ... still fails. So as
expected increasing the recursion limit will still be required
(https://github.com/apache/datafusion/issues/1
alamb commented on PR #14095:
URL: https://github.com/apache/datafusion/pull/14095#issuecomment-2679018958
> > To be clear I think we will still need to increase the recursion limit
in DataFusion to allow the sqllogictest to pass. But until the next sqlparser
upgrade I don't we can do so sa
Omega359 commented on PR #14095:
URL: https://github.com/apache/datafusion/pull/14095#issuecomment-2678942762
> To be clear I think we will still need to increase the recursion limit in
DataFusion to allow the sqllogictest to pass. But until the next sqlparser
upgrade I don't we can do so s
alamb closed pull request #14095: Add recursion limit configuration to
`DFParser`
URL: https://github.com/apache/datafusion/pull/14095
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
alamb commented on PR #14095:
URL: https://github.com/apache/datafusion/pull/14095#issuecomment-2598932383
To be clear I think we will still need to increase the recursion limit in
DataFusion to allow the sqllogictest to pass. But until the next sqlparser
upgrade I don't we can do so safely
alamb commented on PR #14095:
URL: https://github.com/apache/datafusion/pull/14095#issuecomment-2598930685
Converting this to draft
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
tlm365 commented on code in PR #14095:
URL: https://github.com/apache/datafusion/pull/14095#discussion_r1919766960
##
datafusion/sqllogictest/bin/sqllogictests.rs:
##
@@ -52,6 +52,7 @@ const SQLITE_PREFIX: &str = "sqlite";
pub fn main() -> Result<()> {
tokio::runtime::Buil
tlm365 closed pull request #14095: Add recursion limit configuration to
`DFParser`
URL: https://github.com/apache/datafusion/pull/14095
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
alamb commented on code in PR #14095:
URL: https://github.com/apache/datafusion/pull/14095#discussion_r1919168076
##
datafusion/sql/src/parser.rs:
##
@@ -257,6 +257,9 @@ fn ensure_not_set(field: &Option, name: &str) ->
Result<(), ParserError> {
Ok(())
}
+// By default,
tlm365 commented on code in PR #14095:
URL: https://github.com/apache/datafusion/pull/14095#discussion_r1917910609
##
datafusion/sqllogictest/bin/sqllogictests.rs:
##
@@ -52,6 +52,7 @@ const SQLITE_PREFIX: &str = "sqlite";
pub fn main() -> Result<()> {
tokio::runtime::Buil
2010YOUY01 commented on PR #14095:
URL: https://github.com/apache/datafusion/pull/14095#issuecomment-2586368050
Thank you, this fix makes sense to me.
I think we can add the bug reproducer to `sqllogictest` for the regression
test. Although this will be covered in the extended tests,
tlm365 opened a new pull request, #14095:
URL: https://github.com/apache/datafusion/pull/14095
## Which issue does this PR close?
Closes #14091.
## Rationale for this change
## What changes are included in this PR?
Set parser config, now support up to 1
12 matches
Mail list logo
