2010YOUY01 merged PR #16814:
URL: https://github.com/apache/datafusion/pull/16814
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dat
2010YOUY01 commented on PR #16814:
URL: https://github.com/apache/datafusion/pull/16814#issuecomment-3138533679
Thanks again @ding-young and @UBarney
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
UBarney commented on PR #16814:
URL: https://github.com/apache/datafusion/pull/16814#issuecomment-3136567712
> Another advantage of this external profiling approach is that we can
compare different memory allocators side by side (e.g., `jemalloc` and
`mimalloc`).
From what I
ding-young commented on PR #16814:
URL: https://github.com/apache/datafusion/pull/16814#issuecomment-3126700775
> Personally, I prefer to use `time -v dfbench x` to get memory
information. The main advantage is that it doesn't require any extra
compilation of dfbench.
@UBarney Th
ding-young commented on code in PR #16814:
URL: https://github.com/apache/datafusion/pull/16814#discussion_r2235776170
##
benchmarks/src/bin/mem_profile.rs:
##
@@ -0,0 +1,360 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreem
2010YOUY01 commented on PR #16814:
URL: https://github.com/apache/datafusion/pull/16814#issuecomment-3126517250
> Personally, I prefer to use `time -v dfbench x` to get memory
information. The main advantage is that it doesn't require any extra
compilation of dfbench.
Another adv
UBarney commented on PR #16814:
URL: https://github.com/apache/datafusion/pull/16814#issuecomment-3126348457
Personally, I prefer to use `time -v dfbench x` to get memory
information. The main advantage is that it doesn't require any extra
compilation of dfbench.
--
This is an au
UBarney commented on code in PR #16814:
URL: https://github.com/apache/datafusion/pull/16814#discussion_r2235510316
##
benchmarks/src/bin/mem_profile.rs:
##
@@ -0,0 +1,360 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreement
ding-young commented on PR #16814:
URL: https://github.com/apache/datafusion/pull/16814#issuecomment-3126062748
@2010YOUY01 Thank you ! I mentioned your suggestion in follow up issue, and
I'll address it when I add support for nlj benchmark :)
--
This is an automated message from the Apa
ding-young commented on code in PR #16814:
URL: https://github.com/apache/datafusion/pull/16814#discussion_r2234818349
##
benchmarks/src/bin/mem_profile.rs:
##
@@ -0,0 +1,360 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreem
ding-young commented on code in PR #16814:
URL: https://github.com/apache/datafusion/pull/16814#discussion_r2234815857
##
benchmarks/src/bin/mem_profile.rs:
##
@@ -0,0 +1,360 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreem
ding-young commented on code in PR #16814:
URL: https://github.com/apache/datafusion/pull/16814#discussion_r2234803528
##
benchmarks/src/bin/mem_profile.rs:
##
@@ -0,0 +1,360 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreem
ding-young commented on code in PR #16814:
URL: https://github.com/apache/datafusion/pull/16814#discussion_r2234398080
##
benchmarks/README.md:
##
@@ -321,6 +322,64 @@ FLAGS:
...
```
+# Profiling Memory Stats for each benchmark query
+The `mem_profile` program wraps benchmar
ding-young commented on code in PR #16814:
URL: https://github.com/apache/datafusion/pull/16814#discussion_r2234397012
##
benchmarks/src/util/memory.rs:
##
@@ -0,0 +1,54 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
2010YOUY01 commented on code in PR #16814:
URL: https://github.com/apache/datafusion/pull/16814#discussion_r2233621418
##
benchmarks/README.md:
##
@@ -321,6 +322,64 @@ FLAGS:
...
```
+# Profiling Memory Stats for each benchmark query
+The `mem_profile` program wraps benchmar
ding-young commented on PR #16814:
URL: https://github.com/apache/datafusion/pull/16814#issuecomment-3116251667
@2010YOUY01 This is ready for review :) I would love to hear your feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
ding-young commented on code in PR #16814:
URL: https://github.com/apache/datafusion/pull/16814#discussion_r2230051866
##
benchmarks/README.md:
##
@@ -321,6 +322,64 @@ FLAGS:
...
```
+# Profiling Memory Stats for each benchmark query
+The `mem_profile` program wraps benchmar
ding-young opened a new pull request, #16814:
URL: https://github.com/apache/datafusion/pull/16814
## Which issue does this PR close?
- Closes #16720 .
## Rationale for this change
## What changes are included in this PR?
## Are these change
18 matches
Mail list logo
