alamb commented on PR #1808:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1808#issuecomment-2835931034
Thanks again @iffyio and @aharpervc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
iffyio merged PR #1808:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1808
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr
aharpervc commented on code in PR #1808:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1808#discussion_r2052853852
##
src/parser/mod.rs:
##
@@ -5134,6 +5128,76 @@ impl<'a> Parser<'a> {
}))
}
+/// Parse `CREATE FUNCTION` for [MsSql]
+///
+
aharpervc commented on code in PR #1808:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1808#discussion_r2052851172
##
src/parser/mod.rs:
##
@@ -15063,6 +15127,15 @@ impl<'a> Parser<'a> {
message: Box::new(self.parse_expr()?),
}))
}
+
aharpervc commented on code in PR #1808:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1808#discussion_r2052848713
##
src/parser/mod.rs:
##
@@ -5135,6 +5146,63 @@ impl<'a> Parser<'a> {
}))
}
+/// Parse `CREATE FUNCTION` for [SQL Server]
+//
iffyio commented on code in PR #1808:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1808#discussion_r2051414204
##
src/parser/mod.rs:
##
@@ -5135,6 +5146,63 @@ impl<'a> Parser<'a> {
}))
}
+/// Parse `CREATE FUNCTION` for [SQL Server]
+///
+
aharpervc commented on code in PR #1808:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1808#discussion_r2051054233
##
src/parser/mod.rs:
##
@@ -5135,6 +5146,63 @@ impl<'a> Parser<'a> {
}))
}
+/// Parse `CREATE FUNCTION` for [SQL Server]
+//
aharpervc commented on code in PR #1808:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1808#discussion_r2051040245
##
tests/sqlparser_common.rs:
##
@@ -15015,3 +15015,8 @@ fn parse_set_time_zone_alias() {
_ => unreachable!(),
}
}
+
+#[test]
+fn pars
aharpervc commented on code in PR #1808:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1808#discussion_r2051037497
##
src/ast/spans.rs:
##
@@ -2280,6 +2277,12 @@ impl Spanned for TableObject {
}
}
+impl Spanned for BeginEndStatements {
+fn span(&self)
aharpervc commented on code in PR #1808:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1808#discussion_r2047762830
##
tests/sqlparser_mssql.rs:
##
@@ -187,6 +188,386 @@ fn parse_mssql_create_procedure() {
let _ = ms().verified_stmt("CREATE PROCEDURE [foo] AS
aharpervc commented on code in PR #1808:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1808#discussion_r2047778337
##
tests/sqlparser_mssql.rs:
##
@@ -187,6 +188,386 @@ fn parse_mssql_create_procedure() {
let _ = ms().verified_stmt("CREATE PROCEDURE [foo] AS
iffyio commented on code in PR #1808:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1808#discussion_r2050170398
##
src/ast/spans.rs:
##
@@ -2280,6 +2277,12 @@ impl Spanned for TableObject {
}
}
+impl Spanned for BeginEndStatements {
+fn span(&self) ->
aharpervc commented on code in PR #1808:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1808#discussion_r2047853472
##
src/ast/spans.rs:
##
@@ -777,11 +778,9 @@ impl Spanned for ConditionalStatements {
ConditionalStatements::Sequence { statements } =>
aharpervc commented on code in PR #1808:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1808#discussion_r2047767596
##
src/ast/ddl.rs:
##
@@ -2272,6 +2277,10 @@ impl fmt::Display for CreateFunction {
if let Some(CreateFunctionBody::AsAfterOptions(function_
aharpervc commented on code in PR #1808:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1808#discussion_r2047798057
##
src/ast/spans.rs:
##
@@ -777,11 +778,9 @@ impl Spanned for ConditionalStatements {
ConditionalStatements::Sequence { statements } =>
aharpervc commented on code in PR #1808:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1808#discussion_r2047771506
##
tests/sqlparser_mssql.rs:
##
@@ -187,6 +188,386 @@ fn parse_mssql_create_procedure() {
let _ = ms().verified_stmt("CREATE PROCEDURE [foo] AS
aharpervc commented on code in PR #1808:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1808#discussion_r2047770271
##
src/ast/mod.rs:
##
@@ -9211,6 +9253,41 @@ pub enum CopyIntoSnowflakeKind {
Location,
}
+/// Return (MsSql)
+///
+/// for Functions:
+/// R
aharpervc commented on code in PR #1808:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1808#discussion_r2047770466
##
src/ast/mod.rs:
##
@@ -2317,15 +2313,37 @@ impl fmt::Display for ConditionalStatements {
}
Ok(())
}
aharpervc commented on code in PR #1808:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1808#discussion_r2047765609
##
src/parser/mod.rs:
##
@@ -15017,6 +15075,13 @@ impl<'a> Parser<'a> {
}
}
+fn parse_return(&mut self) -> Result {
+let
aharpervc commented on code in PR #1808:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1808#discussion_r2047762830
##
tests/sqlparser_mssql.rs:
##
@@ -187,6 +188,386 @@ fn parse_mssql_create_procedure() {
let _ = ms().verified_stmt("CREATE PROCEDURE [foo] AS
aharpervc commented on code in PR #1808:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1808#discussion_r2047577310
##
src/parser/mod.rs:
##
@@ -580,10 +580,12 @@ impl<'a> Parser<'a> {
// `BEGIN` is a nonstandard but common alias for the
aharpervc commented on code in PR #1808:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1808#discussion_r2047575809
##
src/parser/mod.rs:
##
@@ -5135,6 +5146,63 @@ impl<'a> Parser<'a> {
}))
}
+/// Parse `CREATE FUNCTION` for [SQL Server]
+//
iffyio commented on code in PR #1808:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1808#discussion_r2046107175
##
src/parser/mod.rs:
##
@@ -5135,6 +5146,63 @@ impl<'a> Parser<'a> {
}))
}
+/// Parse `CREATE FUNCTION` for [SQL Server]
+///
+
iffyio commented on code in PR #1808:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1808#discussion_r2046079970
##
src/ast/spans.rs:
##
@@ -777,11 +778,9 @@ impl Spanned for ConditionalStatements {
ConditionalStatements::Sequence { statements } => {
aharpervc commented on code in PR #1808:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1808#discussion_r2045572622
##
src/ast/mod.rs:
##
@@ -4050,6 +4051,13 @@ pub enum Statement {
arguments: Vec,
options: Vec,
},
+/// Return (Mssql)
+
aharpervc commented on code in PR #1808:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1808#discussion_r2045450414
##
src/parser/mod.rs:
##
@@ -5135,6 +5142,69 @@ impl<'a> Parser<'a> {
}))
}
+/// Parse `CREATE FUNCTION` for [MsSql]
+///
+
aharpervc commented on code in PR #1808:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1808#discussion_r2045437472
##
src/parser/mod.rs:
##
@@ -5135,6 +5142,69 @@ impl<'a> Parser<'a> {
}))
}
+/// Parse `CREATE FUNCTION` for [MsSql]
+///
+
aharpervc commented on code in PR #1808:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1808#discussion_r2045435742
##
src/ast/mod.rs:
##
@@ -8368,6 +8387,22 @@ pub enum CreateFunctionBody {
///
/// [BigQuery]:
https://cloud.google.com/bigquery/docs/refe
aharpervc commented on code in PR #1808:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1808#discussion_r2045317219
##
src/parser/mod.rs:
##
@@ -15017,6 +15075,13 @@ impl<'a> Parser<'a> {
}
}
+fn parse_return(&mut self) -> Result {
+let
aharpervc commented on code in PR #1808:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1808#discussion_r2042297201
##
tests/sqlparser_mssql.rs:
##
@@ -255,6 +256,93 @@ fn parse_create_function() {
assert_eq!(
ms().verified_stmt(multi_statement_functi
iffyio commented on code in PR #1808:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1808#discussion_r2043612190
##
src/ast/mod.rs:
##
@@ -9203,6 +9232,30 @@ pub enum CopyIntoSnowflakeKind {
Location,
}
+#[derive(Debug, Clone, PartialEq, PartialOrd, Eq, Ord
aharpervc commented on code in PR #1808:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1808#discussion_r2042834988
##
src/parser/mod.rs:
##
@@ -5135,6 +5142,69 @@ impl<'a> Parser<'a> {
}))
}
+/// Parse `CREATE FUNCTION` for [MsSql]
+///
+
aharpervc commented on code in PR #1808:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1808#discussion_r2042434307
##
src/ast/mod.rs:
##
@@ -4050,6 +4051,16 @@ pub enum Statement {
arguments: Vec,
options: Vec,
},
+/// Return (SQL Server
aharpervc commented on code in PR #1808:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1808#discussion_r2042310768
##
src/parser/mod.rs:
##
@@ -15017,6 +15075,13 @@ impl<'a> Parser<'a> {
}
}
+fn parse_return(&mut self) -> Result {
+let
aharpervc commented on code in PR #1808:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1808#discussion_r2042299062
##
src/ast/mod.rs:
##
@@ -8368,6 +8387,22 @@ pub enum CreateFunctionBody {
///
/// [BigQuery]:
https://cloud.google.com/bigquery/docs/refe
aharpervc commented on code in PR #1808:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1808#discussion_r2042206786
##
src/parser/mod.rs:
##
@@ -5135,6 +5146,63 @@ impl<'a> Parser<'a> {
}))
}
+/// Parse `CREATE FUNCTION` for [SQL Server]
+//
aharpervc commented on code in PR #1808:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1808#discussion_r2042207498
##
src/ast/mod.rs:
##
@@ -4050,6 +4051,16 @@ pub enum Statement {
arguments: Vec,
options: Vec,
},
+/// Return (SQL Server
aharpervc commented on code in PR #1808:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1808#discussion_r2042196775
##
src/parser/mod.rs:
##
@@ -5135,6 +5146,63 @@ impl<'a> Parser<'a> {
}))
}
+/// Parse `CREATE FUNCTION` for [SQL Server]
+//
aharpervc commented on code in PR #1808:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1808#discussion_r204227
##
src/ast/ddl.rs:
##
@@ -2157,6 +2157,10 @@ impl fmt::Display for ClusteredBy {
#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
#[c
iffyio commented on code in PR #1808:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1808#discussion_r2040586609
##
src/ast/mod.rs:
##
@@ -8368,6 +8387,22 @@ pub enum CreateFunctionBody {
///
/// [BigQuery]:
https://cloud.google.com/bigquery/docs/referen
aharpervc commented on code in PR #1808:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1808#discussion_r2040196781
##
tests/sqlparser_mssql.rs:
##
@@ -187,6 +187,145 @@ fn parse_mssql_create_procedure() {
let _ = ms().verified_stmt("CREATE PROCEDURE [foo] AS
aharpervc commented on code in PR #1808:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1808#discussion_r2040136168
##
src/parser/mod.rs:
##
@@ -5135,6 +5146,63 @@ impl<'a> Parser<'a> {
}))
}
+/// Parse `CREATE FUNCTION` for [SQL Server]
+//
aharpervc commented on code in PR #1808:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1808#discussion_r2038224067
##
src/ast/mod.rs:
##
@@ -4050,6 +4051,16 @@ pub enum Statement {
arguments: Vec,
options: Vec,
},
+/// Return (SQL Server
aharpervc commented on code in PR #1808:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1808#discussion_r2039938786
##
src/ast/ddl.rs:
##
@@ -2157,6 +2157,10 @@ impl fmt::Display for ClusteredBy {
#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
#[c
aharpervc commented on code in PR #1808:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1808#discussion_r2038226027
##
tests/sqlparser_hive.rs:
##
@@ -423,7 +423,7 @@ fn parse_create_function() {
}
// Test error in dialect that doesn't support parsing C
aharpervc commented on code in PR #1808:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1808#discussion_r2038224067
##
src/ast/mod.rs:
##
@@ -4050,6 +4051,16 @@ pub enum Statement {
arguments: Vec,
options: Vec,
},
+/// Return (SQL Server
aharpervc opened a new pull request, #1808:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1808
For reference:
https://learn.microsoft.com/en-us/sql/t-sql/statements/create-function-transact-sql?view=sql-server-ver16
In SQL Server, functions look a lot like procedures, wi
47 matches
Mail list logo
