Re: [PR] Add "end to end parquet reading test" for WASM [datafusion]

2025-03-26 Thread via GitHub
alamb commented on code in PR #15362: URL: https://github.com/apache/datafusion/pull/15362#discussion_r200920 ## datafusion/wasmtest/src/lib.rs: ## @@ -185,26 +206,56 @@ mod test { #[wasm_bindgen_test(unsupported = tokio::test)] async fn test_parquet_write() { -

Re: [PR] Add "end to end parquet reading test" for WASM [datafusion]

2025-03-24 Thread via GitHub
alamb merged PR #15362: URL: https://github.com/apache/datafusion/pull/15362 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusi

Re: [PR] Add "end to end parquet reading test" for WASM [datafusion]

2025-03-24 Thread via GitHub
alamb commented on PR #15362: URL: https://github.com/apache/datafusion/pull/15362#issuecomment-2749062757 Thanks again @jsai28 and @XiangpengHao -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[PR] Add "end to end parquet reading test" for WASM [datafusion]

2025-03-24 Thread via GitHub
jsai28 opened a new pull request, #15362: URL: https://github.com/apache/datafusion/pull/15362 ## Which issue does this PR close? - Closes #15357. ## Rationale for this change End to end parquet reading test for WASM. ## What changes are included in this PR? ## Are thes

Re: [PR] Add "end to end parquet reading test" for WASM [datafusion]

2025-03-23 Thread via GitHub
XiangpengHao commented on PR #15362: URL: https://github.com/apache/datafusion/pull/15362#issuecomment-2746395748 LGTM this is really nice, thank you @jsai28 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo