Re: [PR] `datafusion-cli`: Refactor statement execution logic [datafusion]

2025-07-03 Thread via GitHub
alamb commented on PR #16634: URL: https://github.com/apache/datafusion/pull/16634#issuecomment-3033686652 Thanks again @liamzwbao -- keeping the code clean 💯 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] `datafusion-cli`: Refactor statement execution logic [datafusion]

2025-07-03 Thread via GitHub
alamb merged PR #16634: URL: https://github.com/apache/datafusion/pull/16634 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusi

Re: [PR] `datafusion-cli`: Refactor statement execution logic [datafusion]

2025-07-02 Thread via GitHub
alamb commented on code in PR #16634: URL: https://github.com/apache/datafusion/pull/16634#discussion_r2180844132 ## datafusion-cli/src/exec.rs: ## @@ -228,25 +227,43 @@ pub(super) async fn exec_and_print( let statements = DFParser::parse_sql_with_dialect(&sql, dialect.as

[PR] `datafusion-cli`: Refactor statement execution logic [datafusion]

2025-06-30 Thread via GitHub
liamzwbao opened a new pull request, #16634: URL: https://github.com/apache/datafusion/pull/16634 ## Which issue does this PR close? - Closes #16559. ## Rationale for this change ## What changes are included in this PR? Encapsulate s3 region