Re: [PR] [datafusion-spark] Implement ceil&floor function for spark [datafusion]

2025-06-18 Thread via GitHub
alamb commented on PR #15958: URL: https://github.com/apache/datafusion/pull/15958#issuecomment-2983591412 > > @irenjj - I wonder if you would be willing to help pick this PR back up now that we have merged a PR with a bunch of tests from @shehabgamin here: > > > > * [chore: generate

Re: [PR] [datafusion-spark] Implement ceil&floor function for spark [datafusion]

2025-06-17 Thread via GitHub
irenjj commented on PR #15958: URL: https://github.com/apache/datafusion/pull/15958#issuecomment-2982098992 > @irenjj - I wonder if you would be willing to help pick this PR back up now that we have merged a PR with a bunch of tests from @shehabgamin here: > > * [chore: generate basic

Re: [PR] [datafusion-spark] Implement ceil&floor function for spark [datafusion]

2025-06-17 Thread via GitHub
alamb commented on PR #15958: URL: https://github.com/apache/datafusion/pull/15958#issuecomment-2982055315 @irenjj - I wonder if you would be willing to help pick this PR back up now that we have merged a PR with a bunch of tests from @shehabgamin here: - https://github.com/apache/data

Re: [PR] [datafusion-spark] Implement ceil&floor function for spark [datafusion]

2025-05-08 Thread via GitHub
shehabgamin commented on code in PR #15958: URL: https://github.com/apache/datafusion/pull/15958#discussion_r2080822728 ## datafusion/sqllogictest/test_files/spark/math/ceil.slt: ## @@ -0,0 +1,141 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contri

Re: [PR] [datafusion-spark] Implement ceil&floor function for spark [datafusion]

2025-05-08 Thread via GitHub
shehabgamin commented on code in PR #15958: URL: https://github.com/apache/datafusion/pull/15958#discussion_r2080822728 ## datafusion/sqllogictest/test_files/spark/math/ceil.slt: ## @@ -0,0 +1,141 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contri

Re: [PR] [datafusion-spark] Implement ceil&floor function for spark [datafusion]

2025-05-08 Thread via GitHub
andygrove commented on code in PR #15958: URL: https://github.com/apache/datafusion/pull/15958#discussion_r2079751198 ## datafusion/spark/src/function/math/ceil_floor.rs: ## @@ -0,0 +1,720 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

Re: [PR] [datafusion-spark] Implement ceil&floor function for spark [datafusion]

2025-05-07 Thread via GitHub
irenjj commented on code in PR #15958: URL: https://github.com/apache/datafusion/pull/15958#discussion_r2078862746 ## datafusion/spark/src/function/math/ceil_floor.rs: ## @@ -0,0 +1,720 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor lic

Re: [PR] [datafusion-spark] Implement ceil&floor function for spark [datafusion]

2025-05-07 Thread via GitHub
andygrove commented on code in PR #15958: URL: https://github.com/apache/datafusion/pull/15958#discussion_r2078776570 ## datafusion/sqllogictest/test_files/spark/math/ceil.slt: ## @@ -0,0 +1,141 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contribu

Re: [PR] [datafusion-spark] Implement ceil&floor function for spark [datafusion]

2025-05-07 Thread via GitHub
andygrove commented on code in PR #15958: URL: https://github.com/apache/datafusion/pull/15958#discussion_r2078773309 ## datafusion/spark/src/function/math/ceil_floor.rs: ## @@ -0,0 +1,720 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

Re: [PR] [datafusion-spark] Implement ceil&floor function for spark [datafusion]

2025-05-07 Thread via GitHub
andygrove commented on code in PR #15958: URL: https://github.com/apache/datafusion/pull/15958#discussion_r2078772494 ## datafusion/spark/src/function/math/ceil_floor.rs: ## @@ -0,0 +1,720 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

Re: [PR] [datafusion-spark] Implement ceil&floor function for spark [datafusion]

2025-05-07 Thread via GitHub
andygrove commented on code in PR #15958: URL: https://github.com/apache/datafusion/pull/15958#discussion_r2078769590 ## datafusion/spark/src/function/math/ceil_floor.rs: ## @@ -0,0 +1,720 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor