Re: [PR] [datafusion-spark] Implement `factorical` function [datafusion]

2025-06-29 Thread via GitHub
alamb commented on code in PR #16125: URL: https://github.com/apache/datafusion/pull/16125#discussion_r2173714597 ## datafusion/spark/src/function/math/factorial.rs: ## @@ -0,0 +1,196 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor licen

Re: [PR] [datafusion-spark] Implement `factorical` function [datafusion]

2025-06-23 Thread via GitHub
alamb merged PR #16125: URL: https://github.com/apache/datafusion/pull/16125 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusi

Re: [PR] [datafusion-spark] Implement `factorical` function [datafusion]

2025-06-23 Thread via GitHub
alamb commented on PR #16125: URL: https://github.com/apache/datafusion/pull/16125#issuecomment-2997749229 gogogogogogo THanks again @shehabgamin and @tlm365 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [datafusion-spark] Implement `factorical` function [datafusion]

2025-06-23 Thread via GitHub
shehabgamin commented on code in PR #16125: URL: https://github.com/apache/datafusion/pull/16125#discussion_r2162313147 ## datafusion/spark/src/function/math/factorial.rs: ## @@ -0,0 +1,195 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

Re: [PR] [datafusion-spark] Implement `factorical` function [datafusion]

2025-06-23 Thread via GitHub
tlm365 commented on code in PR #16125: URL: https://github.com/apache/datafusion/pull/16125#discussion_r2161947127 ## datafusion/spark/src/function/math/factorial.rs: ## @@ -0,0 +1,195 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor lice

Re: [PR] [datafusion-spark] Implement `factorical` function [datafusion]

2025-06-22 Thread via GitHub
alamb commented on code in PR #16125: URL: https://github.com/apache/datafusion/pull/16125#discussion_r2160337528 ## datafusion/spark/src/function/math/factorial.rs: ## @@ -0,0 +1,195 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor licen

Re: [PR] [datafusion-spark] Implement `factorical` function [datafusion]

2025-06-21 Thread via GitHub
shehabgamin commented on code in PR #16125: URL: https://github.com/apache/datafusion/pull/16125#discussion_r2160232657 ## datafusion/spark/src/function/math/factorial.rs: ## @@ -0,0 +1,195 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

Re: [PR] [datafusion-spark] Implement `factorical` function [datafusion]

2025-06-21 Thread via GitHub
shehabgamin commented on PR #16125: URL: https://github.com/apache/datafusion/pull/16125#issuecomment-2993934242 > Thank you @tlm365 -- this looks great to me > > > > What do you think @shehabgamin -- anything else that this PR should have (I am hoping to use it as an exampl

Re: [PR] [datafusion-spark] Implement `factorical` function [datafusion]

2025-06-21 Thread via GitHub
alamb commented on code in PR #16125: URL: https://github.com/apache/datafusion/pull/16125#discussion_r2160001711 ## datafusion/spark/src/function/math/factorial.rs: ## @@ -0,0 +1,195 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor licen

Re: [PR] [datafusion-spark] Implement `factorical` function [datafusion]

2025-06-20 Thread via GitHub
tlm365 commented on code in PR #16125: URL: https://github.com/apache/datafusion/pull/16125#discussion_r2159851714 ## datafusion/spark/src/function/math/factorial.rs: ## @@ -0,0 +1,199 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor lice

Re: [PR] [datafusion-spark] Implement `factorical` function [datafusion]

2025-06-20 Thread via GitHub
alamb commented on code in PR #16125: URL: https://github.com/apache/datafusion/pull/16125#discussion_r2159578815 ## datafusion/spark/src/function/math/factorial.rs: ## @@ -0,0 +1,199 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor licen

Re: [PR] [datafusion-spark] Implement `factorical` function [datafusion]

2025-06-20 Thread via GitHub
alamb commented on PR #16125: URL: https://github.com/apache/datafusion/pull/16125#issuecomment-2992635554 FYI @shehabgamin -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [datafusion-spark] Implement `factorical` function [datafusion]

2025-06-17 Thread via GitHub
tlm365 commented on PR #16125: URL: https://github.com/apache/datafusion/pull/16125#issuecomment-2982855702 > @tlm365 - I wonder if you would be willing to help pick this PR back up now that we have merged a PR with a bunch of tests from @shehabgamin here: > > * [chore: generate b

Re: [PR] [datafusion-spark] Implement `factorical` function [datafusion]

2025-06-17 Thread via GitHub
alamb commented on PR #16125: URL: https://github.com/apache/datafusion/pull/16125#issuecomment-2982055127 @tlm365 - I wonder if you would be willing to help pick this PR back up now that we have merged a PR with a bunch of tests from @shehabgamin here: - https://github.com/apache/dataf

[PR] [datafusion-spark] Implement `factorical` function [datafusion]

2025-05-20 Thread via GitHub
tlm365 opened a new pull request, #16125: URL: https://github.com/apache/datafusion/pull/16125 ## Which issue does this PR close? - Closes #16124 . ## Rationale for this change ## What changes are included in this PR? Implement spark-compatible `factori