andygrove merged PR #15947:
URL: https://github.com/apache/datafusion/pull/15947
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@data
andygrove commented on PR #15947:
URL: https://github.com/apache/datafusion/pull/15947#issuecomment-2863214007
I agree with @alamb that we should go ahead and merge this, and then I can
update Comet to use it so we have confidence that this approach is working (I
think it is). Thanks for th
andygrove commented on PR #15947:
URL: https://github.com/apache/datafusion/pull/15947#issuecomment-2860489815
> Thanks @shehabgamin and @andygrove
>
> What I think we should do is to merge this PR and file a follow on ticket
for any follow on performance optimizations (aka avoid allo
andygrove commented on code in PR #15947:
URL: https://github.com/apache/datafusion/pull/15947#discussion_r2078546921
##
datafusion/spark/src/function/math/hex.rs:
##
@@ -0,0 +1,404 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license
alamb commented on code in PR #15947:
URL: https://github.com/apache/datafusion/pull/15947#discussion_r2078491599
##
datafusion/sqllogictest/test_files/spark/math/hex.slt:
##
@@ -0,0 +1,26 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor li
shehabgamin commented on code in PR #15947:
URL: https://github.com/apache/datafusion/pull/15947#discussion_r2077032231
##
datafusion/sqllogictest/test_files/spark/math/hex.slt:
##
@@ -0,0 +1,26 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contribu
alamb commented on code in PR #15947:
URL: https://github.com/apache/datafusion/pull/15947#discussion_r2074113601
##
datafusion/spark/src/function/math/hex.rs:
##
@@ -0,0 +1,404 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agr
alamb commented on code in PR #15947:
URL: https://github.com/apache/datafusion/pull/15947#discussion_r2074114006
##
datafusion/spark/src/function/math/hex.rs:
##
@@ -0,0 +1,404 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agr
shehabgamin commented on code in PR #15947:
URL: https://github.com/apache/datafusion/pull/15947#discussion_r2074093408
##
datafusion/spark/src/function/math/hex.rs:
##
@@ -0,0 +1,404 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor licen
alamb commented on code in PR #15947:
URL: https://github.com/apache/datafusion/pull/15947#discussion_r2073954485
##
datafusion/spark/src/function/math/hex.rs:
##
@@ -0,0 +1,404 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agr
andygrove commented on code in PR #15947:
URL: https://github.com/apache/datafusion/pull/15947#discussion_r2073711784
##
datafusion/spark/src/function/math/hex.rs:
##
@@ -0,0 +1,404 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license
andygrove opened a new pull request, #15947:
URL: https://github.com/apache/datafusion/pull/15947
## Which issue does this PR close?
Part of https://github.com/apache/datafusion/issues/15914 and
https://github.com/apache/datafusion-comet/issues/1704
## Rationale for thi
12 matches
Mail list logo
