Re: [PR] [datafusion-spark] Add Spark-compatible `char` expression [datafusion]

2025-05-16 Thread via GitHub
alamb commented on PR #15994: URL: https://github.com/apache/datafusion/pull/15994#issuecomment-2887574752 Makes sense to me 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] [datafusion-spark] Add Spark-compatible `char` expression [datafusion]

2025-05-16 Thread via GitHub
andygrove commented on PR #15994: URL: https://github.com/apache/datafusion/pull/15994#issuecomment-2887549152 > Thanks @andygrove and @shehabgamin -- how close do you think we are to being able to open up the `datafusion-spark` floodgates to contributors? Ideally, I would like to wai

Re: [PR] [datafusion-spark] Add Spark-compatible `char` expression [datafusion]

2025-05-16 Thread via GitHub
alamb commented on PR #15994: URL: https://github.com/apache/datafusion/pull/15994#issuecomment-2887545046 Thanks @andygrove and @shehabgamin -- how close do you think we are to being able to open up the `datafusion-spark` floodgates to contributors? -- This is an automated message from t

Re: [PR] [datafusion-spark] Add Spark-compatible `char` expression [datafusion]

2025-05-16 Thread via GitHub
alamb merged PR #15994: URL: https://github.com/apache/datafusion/pull/15994 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusi

Re: [PR] [datafusion-spark] Add Spark-compatible `char` expression [datafusion]

2025-05-09 Thread via GitHub
andygrove commented on code in PR #15994: URL: https://github.com/apache/datafusion/pull/15994#discussion_r2082124914 ## datafusion/spark/src/function/string/char.rs: ## @@ -0,0 +1,130 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor lice

Re: [PR] [datafusion-spark] Add Spark-compatible `char` expression [datafusion]

2025-05-08 Thread via GitHub
tlm365 commented on code in PR #15994: URL: https://github.com/apache/datafusion/pull/15994#discussion_r2080913084 ## datafusion/spark/src/function/string/char.rs: ## @@ -0,0 +1,130 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license

[PR] [datafusion-spark] Add Spark-compatible `char` expression [datafusion]

2025-05-08 Thread via GitHub
andygrove opened a new pull request, #15994: URL: https://github.com/apache/datafusion/pull/15994 ## Which issue does this PR close? N/A ## Rationale for this change Add another Spark expression. This expression was originally contributed to Comet by @vai

Re: [PR] [datafusion-spark] Add Spark-compatible `char` expression [datafusion]

2025-05-08 Thread via GitHub
andygrove commented on PR #15994: URL: https://github.com/apache/datafusion/pull/15994#issuecomment-2863253288 @shehabgamin @alamb fyi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [datafusion-spark] Add Spark-compatible `char` expression [datafusion]

2025-05-08 Thread via GitHub
vaibhawvipul commented on PR #15994: URL: https://github.com/apache/datafusion/pull/15994#issuecomment-2863263757 Thank you for mention! ❤️ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp