lovasoa commented on PR #1738:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1738#issuecomment-2678995461
> Any chance you can pull the doc strings from
https://github.com/lovasoa/sqlparser-rs/commit/4d101b0f4af2b9381bea63ca6d58f61926e6b10f
as well?
I did. I think this
lovasoa commented on PR #1738:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1738#issuecomment-2679030792
> It appears there are a few failed tests
:grimacing: I had forgotten to run `cargo test --all-features`. It's fixed
now.
--
This is an automated message from t
alamb commented on PR #1738:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1738#issuecomment-2679021258
It appears there are a few failed tests:
alamb commented on PR #1738:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1738#issuecomment-2678918594
Looking quite nice!
Any chance you can pull the doc strings from
https://github.com/lovasoa/sqlparser-rs/pull/1/commits/4d101b0f4af2b9381bea63ca6d58f61926e6b10f
as w
lovasoa commented on PR #1738:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1738#issuecomment-2678881467
Ok, ast-grep is [a bit of a pita to use with
rust](https://github.com/ast-grep/ast-grep/issues/853), but I managed to get it
to do most of the work with the following rul
alamb commented on PR #1738:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1738#issuecomment-2678717651
@lovasoa here is a proposed contribution:
- https://github.com/lovasoa/sqlparser-rs/pull/1
If you like that, I think we can apply the same thing to the other tests
alamb commented on PR #1738:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1738#issuecomment-2678615822
> If someone wants to volunteer help...
I will post a note in DataFUsion slack and see if I can find anyone to help
In terms of logitistics, I suggest people:
lovasoa commented on PR #1738:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1738#issuecomment-2678028420
If someone wants to volunteer help...
--
This is an automated messa
lovasoa commented on code in PR #1738:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1738#discussion_r1967358401
##
src/ast/value.rs:
##
@@ -26,10 +26,25 @@ use bigdecimal::BigDecimal;
#[cfg(feature = "serde")]
use serde::{Deserialize, Serialize};
-use crate::
eliaperantoni commented on code in PR #1738:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1738#discussion_r1967336588
##
src/ast/value.rs:
##
@@ -26,10 +26,25 @@ use bigdecimal::BigDecimal;
#[cfg(feature = "serde")]
use serde::{Deserialize, Serialize};
-use c
lovasoa commented on code in PR #1738:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1738#discussion_r1967171526
##
tests/sqlparser_bigquery.rs:
##
@@ -50,112 +50,146 @@ fn parse_literal_string() {
let select = dialect.verified_only_select(sql);
assert_e
lovasoa commented on code in PR #1738:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1738#discussion_r1967169666
##
src/ast/value.rs:
##
@@ -26,10 +26,25 @@ use bigdecimal::BigDecimal;
#[cfg(feature = "serde")]
use serde::{Deserialize, Serialize};
-use crate::
eliaperantoni commented on code in PR #1738:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1738#discussion_r1967128017
##
src/ast/value.rs:
##
@@ -26,10 +26,25 @@ use bigdecimal::BigDecimal;
#[cfg(feature = "serde")]
use serde::{Deserialize, Serialize};
-use c
alamb commented on PR #1738:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1738#issuecomment-2676821051
FYI @eliaperantoni -- any chance you are willing to help our with this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please
lovasoa commented on PR #1738:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1738#issuecomment-2675136484
feel free to edit the code directly without asking me first :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
lovasoa opened a new pull request, #1738:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1738
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
16 matches
Mail list logo
