Re: [PR] (debugging) re-enable sort fuzz test [datafusion]

2025-06-21 Thread via GitHub
adriangb commented on code in PR #16491: URL: https://github.com/apache/datafusion/pull/16491#discussion_r2160038608 ## datafusion/common/Cargo.toml: ## @@ -55,6 +55,7 @@ apache-avro = { version = "0.17", default-features = false, features = [ arrow = { workspace = true } arr

Re: [PR] (debugging) re-enable sort fuzz test [datafusion]

2025-06-21 Thread via GitHub
adriangb commented on PR #16491: URL: https://github.com/apache/datafusion/pull/16491#issuecomment-2993586710 I understand why but I do find it kind of strange that `Literal::new()` calls `Display` on `ScalarValue`. I wonder if we could just make the `Field` name `"lit"`? -- This is an a

Re: [PR] (debugging) re-enable sort fuzz test [datafusion]

2025-06-21 Thread via GitHub
adriangb commented on PR #16491: URL: https://github.com/apache/datafusion/pull/16491#issuecomment-2993585382 I think with these fixes to `Display` the tests will pass consistently. I used this script to test: ```python #!/usr/bin/env python3 import argparse import

Re: [PR] (debugging) re-enable sort fuzz test [datafusion]

2025-06-21 Thread via GitHub
alamb commented on PR #16491: URL: https://github.com/apache/datafusion/pull/16491#issuecomment-2993537951 Context for anyone interested: https://github.com/apache/datafusion/issues/16452#issuecomment-2993339850 -- This is an automated message from the Apache Git Service. To respond to th

[PR] (debugging) re-enable sort fuzz test [datafusion]

2025-06-20 Thread via GitHub
adriangb opened a new pull request, #16491: URL: https://github.com/apache/datafusion/pull/16491 1. Re-enable test, verify CI fails. 2. Revert https://github.com/apache/datafusion/pull/15770 (suspected cause). 3. Verify CI doesn't fail after multiple runs. -- This is an automated mes