alamb closed issue #14408: Test DataFusion 45.0.0 with Sail
URL: https://github.com/apache/datafusion/issues/14408
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
alamb commented on issue #14408:
URL: https://github.com/apache/datafusion/issues/14408#issuecomment-2656435262
Since we have released DF 45 I think we can claim the testing is complete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
alamb commented on issue #14408:
URL: https://github.com/apache/datafusion/issues/14408#issuecomment-2648260952
> > > [@findepi](https://github.com/findepi) do you mean we should relax the
check to ignore nullable / non nullable annotations? -- I think that would
probably be ok too.
> >
shehabgamin commented on issue #14408:
URL: https://github.com/apache/datafusion/issues/14408#issuecomment-2644716584
> > [@findepi](https://github.com/findepi) do you mean we should relax the
check to ignore nullable / non nullable annotations? -- I think that would
probably be ok too.
alamb commented on issue #14408:
URL: https://github.com/apache/datafusion/issues/14408#issuecomment-2643703822
From my perspective it seems like all the tests in DataFusion are passing,
so clearly we have some sort of test coverage / gap
@shehabgamin I wonder if this would be a goo
findepi commented on issue #14408:
URL: https://github.com/apache/datafusion/issues/14408#issuecomment-2640948296
> [@findepi](https://github.com/findepi) do you mean we should relax the
check to ignore nullable / non nullable annotations? -- I think that would
probably be ok too.
ye
alamb commented on issue #14408:
URL: https://github.com/apache/datafusion/issues/14408#issuecomment-2639747760
> Not sure if this is the right file to be looking at, but it's where the
error comes from (`Physical input schema should be the same as the one
converted from logical input schem
shehabgamin commented on issue #14408:
URL: https://github.com/apache/datafusion/issues/14408#issuecomment-2633137719
Not sure if this is the right file to be looking at, but it's where the
error comes from (`Physical input schema should be the same as the one
converted from logical input
shehabgamin commented on issue #14408:
URL: https://github.com/apache/datafusion/issues/14408#issuecomment-2632271140
@alamb This doesn't surprise me considering that Sail doesn't use SQLToRel.
My concern isn't necessarily with TPC-DS 66, but rather the implications of
this error. There is
alamb commented on issue #14408:
URL: https://github.com/apache/datafusion/issues/14408#issuecomment-2630691503
In terms of TPC-DS errors, I think we have tests for those queries as part
of the regression tests
-
https://github.com/apache/datafusion/blob/main/datafusion/core/tests/tpcds_
findepi commented on issue #14408:
URL: https://github.com/apache/datafusion/issues/14408#issuecomment-2629542547
> Physical input schema should be the same as the one converted from logical
input schema.
> Differences:
> - field nullability at index 7 [#98]: (physical) false vs (log
Omega359 commented on issue #14408:
URL: https://github.com/apache/datafusion/issues/14408#issuecomment-2629465143
I'd be curious if this could be narrowed down via git bisect. Probably would
need a small script to do it and a quick test case
--
This is an automated message from the Apach
shehabgamin commented on issue #14408:
URL: https://github.com/apache/datafusion/issues/14408#issuecomment-2629235081
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
shehabgamin opened a new issue, #14408:
URL: https://github.com/apache/datafusion/issues/14408
### Is your feature request related to a problem or challenge?
We would like to make sure that DataFusion 45.0.0 works with Sail before
creating the release candidate.
### Describe th
14 matches
Mail list logo
