alamb commented on issue #6543:
URL: https://github.com/apache/datafusion/issues/6543#issuecomment-2950723461
> What is the best place to create this visitor?
I am not 100% sure about an alias
In general I think code that would create unique aliases would belong in the
planner
osipovartem commented on issue #6543:
URL: https://github.com/apache/datafusion/issues/6543#issuecomment-2948722839
What is the best place to create this visitor?
Create new visitors/select_expr_aliases.rs near
https://github.com/apache/datafusion-sqlparser-rs/blob/main/src/ast/visitor.r
alamb commented on issue #6543:
URL: https://github.com/apache/datafusion/issues/6543#issuecomment-2944658229
> would it be correct to use statement visitors here to add unique aliases?
I think that is actually a pretty neat idea -- specifically add the aliases
in the SQL planner
osipovartem commented on issue #6543:
URL: https://github.com/apache/datafusion/issues/6543#issuecomment-2943653445
Here is the same issue
```sql
CREATE TABLE test (col1 DATE, col2 DATE);
INSERT INTO test
SELECT TO_DATE('2013-05-08T23:39:20.123'),
TO_DATE('2013-05-08T23:39
laisee commented on issue #6543:
URL: https://github.com/apache/datafusion/issues/6543#issuecomment-2716497178
Note extra use case that fails (silently) when joining 2 tables from
different data connectors with common column name. Adding here as the error may
not be detected i.e. no error c
alamb commented on issue #6543:
URL: https://github.com/apache/datafusion/issues/6543#issuecomment-2686160994
> what can we do about this ?
> can i update the slt test for this test ?
Whatever is rewriting the function call probably should add an alias 🤔
--
This is an automated
jatin510 commented on issue #6543:
URL: https://github.com/apache/datafusion/issues/6543#issuecomment-2685810432
while working on : https://github.com/apache/datafusion/pull/14752
came across this issue
```
for sql query: SELECT iszero(1.0), iszero(0.0), iszero(-0.0), iszero
findepi commented on issue #6543:
URL: https://github.com/apache/datafusion/issues/6543#issuecomment-2483689897
This would be great item in the broader scope of
https://github.com/apache/datafusion/issues/12723, which intents to make
DataFusion Logical Plans be state of the art.
--
This