Re: [I] Support columns having the same alias [datafusion]

2025-06-06 Thread via GitHub
alamb commented on issue #6543: URL: https://github.com/apache/datafusion/issues/6543#issuecomment-2950723461 > What is the best place to create this visitor? I am not 100% sure about an alias In general I think code that would create unique aliases would belong in the planner

Re: [I] Support columns having the same alias [datafusion]

2025-06-06 Thread via GitHub
osipovartem commented on issue #6543: URL: https://github.com/apache/datafusion/issues/6543#issuecomment-2948722839 What is the best place to create this visitor? Create new visitors/select_expr_aliases.rs near https://github.com/apache/datafusion-sqlparser-rs/blob/main/src/ast/visitor.r

Re: [I] Support columns having the same alias [datafusion]

2025-06-05 Thread via GitHub
alamb commented on issue #6543: URL: https://github.com/apache/datafusion/issues/6543#issuecomment-2944658229 > would it be correct to use statement visitors here to add unique aliases? I think that is actually a pretty neat idea -- specifically add the aliases in the SQL planner

Re: [I] Support columns having the same alias [datafusion]

2025-06-05 Thread via GitHub
osipovartem commented on issue #6543: URL: https://github.com/apache/datafusion/issues/6543#issuecomment-2943653445 Here is the same issue ```sql CREATE TABLE test (col1 DATE, col2 DATE); INSERT INTO test SELECT TO_DATE('2013-05-08T23:39:20.123'), TO_DATE('2013-05-08T23:39

Re: [I] Support columns having the same alias [datafusion]

2025-03-11 Thread via GitHub
laisee commented on issue #6543: URL: https://github.com/apache/datafusion/issues/6543#issuecomment-2716497178 Note extra use case that fails (silently) when joining 2 tables from different data connectors with common column name. Adding here as the error may not be detected i.e. no error c

Re: [I] Support columns having the same alias [datafusion]

2025-02-26 Thread via GitHub
alamb commented on issue #6543: URL: https://github.com/apache/datafusion/issues/6543#issuecomment-2686160994 > what can we do about this ? > can i update the slt test for this test ? Whatever is rewriting the function call probably should add an alias 🤔 -- This is an automated

Re: [I] Support columns having the same alias [datafusion]

2025-02-26 Thread via GitHub
jatin510 commented on issue #6543: URL: https://github.com/apache/datafusion/issues/6543#issuecomment-2685810432 while working on : https://github.com/apache/datafusion/pull/14752 came across this issue ``` for sql query: SELECT iszero(1.0), iszero(0.0), iszero(-0.0), iszero

Re: [I] Support columns having the same alias [datafusion]

2024-11-18 Thread via GitHub
findepi commented on issue #6543: URL: https://github.com/apache/datafusion/issues/6543#issuecomment-2483689897 This would be great item in the broader scope of https://github.com/apache/datafusion/issues/12723, which intents to make DataFusion Logical Plans be state of the art. -- This