Re: [I] Physical plan pushdown for volatile predicates [datafusion]

2025-07-30 Thread via GitHub
theirix commented on issue #16545: URL: https://github.com/apache/datafusion/issues/16545#issuecomment-3137490258 Thank you for the improvement, @adriangb ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [I] Physical plan pushdown for volatile predicates [datafusion]

2025-07-29 Thread via GitHub
alamb closed issue #16545: Physical plan pushdown for volatile predicates URL: https://github.com/apache/datafusion/issues/16545 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] Physical plan pushdown for volatile predicates [datafusion]

2025-07-22 Thread via GitHub
adriangb commented on issue #16545: URL: https://github.com/apache/datafusion/issues/16545#issuecomment-3104993647 It seems reasonable to me to blacklist some filters. But given that users can create arbitrary trait implementations for PhysicalExpr we obviously can't black list everything.

Re: [I] Physical plan pushdown for volatile predicates [datafusion]

2025-07-22 Thread via GitHub
theirix commented on issue #16545: URL: https://github.com/apache/datafusion/issues/16545#issuecomment-3104952628 > > I expect the physical plan optimiser doesn't perform pushdown of volatile predicates. > > I am not sure -- does this result in wrong results? We don't observe i

Re: [I] Physical plan pushdown for volatile predicates [datafusion]

2025-07-21 Thread via GitHub
alamb commented on issue #16545: URL: https://github.com/apache/datafusion/issues/16545#issuecomment-3097890993 > I expect the physical plan optimiser doesn't perform pushdown of volatile predicates. I am not sure -- does this result in wrong results? It does make sense in gen

Re: [I] Physical plan pushdown for volatile predicates [datafusion]

2025-07-19 Thread via GitHub
theirix commented on issue #16545: URL: https://github.com/apache/datafusion/issues/16545#issuecomment-3092538385 @alamb @adriangb, given your most recent work on pushdowns, does it appear to be a bug? -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [I] Physical plan pushdown for volatile predicates [datafusion]

2025-07-02 Thread via GitHub
theirix commented on issue #16545: URL: https://github.com/apache/datafusion/issues/16545#issuecomment-3029427291 @findepi could you please tell if this behaviour makes sense? If not, I could try fixing the physical plan as in #13268, where you have a review -- This is an automated messag

[I] Physical plan pushdown for volatile predicates [datafusion]

2025-06-25 Thread via GitHub
theirix opened a new issue, #16545: URL: https://github.com/apache/datafusion/issues/16545 ### Describe the bug This is a follow-up to a discussion in https://github.com/apache/datafusion/pull/16325#issuecomment-2985522134, which is not directly related to table sampling but could af