alamb closed issue #14610: Optimize `repeat` function
URL: https://github.com/apache/datafusion/issues/14610
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
alamb commented on issue #14610:
URL: https://github.com/apache/datafusion/issues/14610#issuecomment-2654015159
Thanks @zjregee
> This seems to work well when the number of repetitions is small, because
it reduces the number of memory copies, but when the number of repetitions is
la
alamb commented on issue #14610:
URL: https://github.com/apache/datafusion/issues/14610#issuecomment-2654019734
Hi @zjregee -- would it be possible to iterate through the input once and
calculate how much space is needed and then create a StringBuilder with the
appropriate capacity via
[`
zjregee commented on issue #14610:
URL: https://github.com/apache/datafusion/issues/14610#issuecomment-2653494265
Hi, @alamb, I have a few questions and hope to get some help.
Is the optimization mentioned here similar to using the following method
instead?
```rust
for _ in
alamb commented on issue #14610:
URL: https://github.com/apache/datafusion/issues/14610#issuecomment-2650888782
I think this is a good first issue as the code is self contained, the issue
explained well and there are benchmarks
You can run
```shell
cargo bench --bench repeat
alamb opened a new issue, #14610:
URL: https://github.com/apache/datafusion/issues/14610
### Is your feature request related to a problem or challenge?
While reviewing https://github.com/apache/datafusion/pull/14575 from
@wForget I noticed that the implementation of `repeat` could be
