Re: [I] Migrate physical plan tests to `insta` [datafusion]

2025-03-24 Thread via GitHub
jayzhan211 closed issue #15248: Migrate physical plan tests to `insta` URL: https://github.com/apache/datafusion/issues/15248 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [I] Migrate physical plan tests to `insta` [datafusion]

2025-03-24 Thread via GitHub
Shreyaskr1409 commented on issue #15248: URL: https://github.com/apache/datafusion/issues/15248#issuecomment-2749205655 > oh, also joins I think (e.g. `join_splitted_batch`) I will wrap up everything and cross check in next PR. we can proceed any changes to be made there. -- This i

Re: [I] Migrate physical plan tests to `insta` [datafusion]

2025-03-24 Thread via GitHub
blaginin commented on issue #15248: URL: https://github.com/apache/datafusion/issues/15248#issuecomment-2749195939 oh, also joins I think (e.g. `join_splitted_batch`) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [I] Migrate physical plan tests to `insta` [datafusion]

2025-03-24 Thread via GitHub
Shreyaskr1409 commented on issue #15248: URL: https://github.com/apache/datafusion/issues/15248#issuecomment-2749142273 > [@Shreyaskr1409](https://github.com/Shreyaskr1409) are there any more tests to migrate? Or is this ticket complete? @alamb tests for `sort` are still left. The

Re: [I] Migrate physical plan tests to `insta` [datafusion]

2025-03-24 Thread via GitHub
blaginin commented on issue #15248: URL: https://github.com/apache/datafusion/issues/15248#issuecomment-2749139298 I think there are a bit more to update, e.g. https://github.com/apache/datafusion/blob/0ff89844a2f2c7a3bbcaff995db7e464deaeb997/datafusion/physical-plan/src/windows/boun

Re: [I] Migrate physical plan tests to `insta` [datafusion]

2025-03-24 Thread via GitHub
alamb commented on issue #15248: URL: https://github.com/apache/datafusion/issues/15248#issuecomment-2749132726 @Shreyaskr1409 are there any more tests to migrate? Or is this ticket complete? -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [I] Migrate physical plan tests to `insta` [datafusion]

2025-03-15 Thread via GitHub
Shreyaskr1409 commented on issue #15248: URL: https://github.com/apache/datafusion/issues/15248#issuecomment-2726571067 take -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[I] Migrate physical plan tests to `insta` [datafusion]

2025-03-15 Thread via GitHub
blaginin opened a new issue, #15248: URL: https://github.com/apache/datafusion/issues/15248 In https://github.com/apache/datafusion/issues/15178, we're switching hard-coded constants in tests to `insta.` This issue targets updating **physical plan tests** (`datafusion/physical-plan)