Re: [I] Inability to cancel certain plans [datafusion]

2025-05-27 Thread via GitHub
pepijnve commented on issue #16193: URL: https://github.com/apache/datafusion/issues/16193#issuecomment-2915032807 I'll change the title to be less broad and focus on cancelling aggregations instead. -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [I] Inability to cancel certain plans [datafusion]

2025-05-27 Thread via GitHub
alamb commented on issue #16193: URL: https://github.com/apache/datafusion/issues/16193#issuecomment-2914274753 > [@alamb](https://github.com/alamb) how are you guys handling general housekeeping in the issue tracker? Should I close this issue since it's a specific example of [#15314](https

Re: [I] Inability to cancel certain plans [datafusion]

2025-05-27 Thread via GitHub
pepijnve commented on issue #16193: URL: https://github.com/apache/datafusion/issues/16193#issuecomment-2913983580 @alamb how are you guys handling general housekeeping in the issue tracker? Should I close this issue since it's a specific example of #15314? -- This is an automated message

Re: [I] Inability to cancel certain plans [datafusion]

2025-05-27 Thread via GitHub
pepijnve commented on issue #16193: URL: https://github.com/apache/datafusion/issues/16193#issuecomment-2913693236 Yes this is more or less the same issue. PR #14028 proposed adding a yield point at the leaf of the plan when moving from one file to the next. This PR adds yield points closer

Re: [I] Inability to cancel certain plans [datafusion]

2025-05-27 Thread via GitHub
alamb commented on issue #16193: URL: https://github.com/apache/datafusion/issues/16193#issuecomment-2913495619 I believe this sounds similar to from this PR from @jeffreyssmith2nd - https://github.com/apache/datafusion/issues/14036 @carols10cents has made a benchmark here: - h

Re: [I] Inability to cancel certain plans [datafusion]

2025-05-27 Thread via GitHub
zhuqi-lucas commented on issue #16193: URL: https://github.com/apache/datafusion/issues/16193#issuecomment-2912804691 Submitted the PR https://github.com/apache/datafusion/issues/16193 The PR is limited to solve aggregate with no group streaming, we can extend to more cases if it's no

Re: [I] Inability to cancel certain plans [datafusion]

2025-05-27 Thread via GitHub
zhuqi-lucas commented on issue #16193: URL: https://github.com/apache/datafusion/issues/16193#issuecomment-2912756722 take -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[I] Inability to cancel certain plans [datafusion]

2025-05-27 Thread via GitHub
pepijnve opened a new issue, #16193: URL: https://github.com/apache/datafusion/issues/16193 ### Describe the bug Canceling queries is done by dropping the corresponding `RecordBatchStream`. This can be done using tokio's `switch!` macro as can be seen in the CLI application's handlin