milenkovicm commented on issue #1278:
URL:
https://github.com/apache/datafusion-python/issues/1278#issuecomment-3429365793
`aggregate` may have the same issue like `select` as it expects column name
as a string, I'll leave those two to you @timsaucer
--
This is an automated message from
ntjohnson1 commented on issue #1278:
URL:
https://github.com/apache/datafusion-python/issues/1278#issuecomment-3423477322
I definitely think a single `select` would be nice ergonomically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
milenkovicm commented on issue #1278:
URL:
https://github.com/apache/datafusion-python/issues/1278#issuecomment-3423430457
if we do not have special handle for column names I would agree with you,
one select may make more sense. If we have to check for column name before we
`parse_sql` I b
timsaucer commented on issue #1278:
URL:
https://github.com/apache/datafusion-python/issues/1278#issuecomment-3423415082
I can see how it might be preferable to some to have it split out, but I
also feel like just having one `select` is very ergonomic. Asking for another
opinion from some
milenkovicm commented on issue #1278:
URL:
https://github.com/apache/datafusion-python/issues/1278#issuecomment-3423235372
[looking at
spark](https://spark.apache.org/docs/latest/api/python/reference/pyspark.sql/api/pyspark.sql.DataFrame.select.html#pyspark.sql.DataFrame.select)
it looks l
timsaucer commented on issue #1278:
URL:
https://github.com/apache/datafusion-python/issues/1278#issuecomment-3406750424
I do think we want `select` but it just can't be the snippet I shared
before. Instead I think it needs to check if the string matches a column name
first. If so, make a
timsaucer commented on issue #1278:
URL:
https://github.com/apache/datafusion-python/issues/1278#issuecomment-340684
I think when we have a string we want to first check to see if it is a
column name. If so, create a column expression. If not, try sql parsing.
--
This is an automated
timsaucer opened a new issue, #1278:
URL: https://github.com/apache/datafusion-python/issues/1278
**Is your feature request related to a problem or challenge? Please describe
what you are trying to do.**
This is a follow on to
https://github.com/apache/datafusion-python/issues/1273
milenkovicm commented on issue #1278:
URL:
https://github.com/apache/datafusion-python/issues/1278#issuecomment-3412620111
i hope to tick off few of them off the list this weekend
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
milenkovicm commented on issue #1278:
URL:
https://github.com/apache/datafusion-python/issues/1278#issuecomment-3407425098
I have no strong opinion Tim, I'm split between keeping it as it is and
change it
--
This is an automated message from the Apache Git Service.
To respond to the mess
milenkovicm commented on issue #1278:
URL:
https://github.com/apache/datafusion-python/issues/1278#issuecomment-3406712056
Have you changed your mind about select Tim? I'm stuck next few days but may
help if needed
--
This is an automated message from the Apache Git Service.
To respond
timsaucer commented on issue #1278:
URL:
https://github.com/apache/datafusion-python/issues/1278#issuecomment-3406551401
cc @milenkovicm @K-dash
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
12 matches
Mail list logo
