kevinjqliu commented on issue #80:
URL: https://github.com/apache/datafusion-site/issues/80#issuecomment-3119858703
From https://issues.apache.org/jira/browse/INFRA-27070, Apache infra pointed
to this example to add CSP
https://privacy.apache.org/examples/youtube-html/with-youtube-api.html
kevinjqliu commented on issue #80:
URL: https://github.com/apache/datafusion-site/issues/80#issuecomment-3114551179
There's precedence to add new CSP. Let's see what Apache infra says
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
alamb commented on issue #80:
URL: https://github.com/apache/datafusion-site/issues/80#issuecomment-3114540526
Oh, but I see that requires making a new github app -- that sounds
complicated
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
alamb commented on issue #80:
URL: https://github.com/apache/datafusion-site/issues/80#issuecomment-3114535175
Or maybe we can host the .js directly on our site?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
kevinjqliu commented on issue #80:
URL: https://github.com/apache/datafusion-site/issues/80#issuecomment-311756
https://issues.apache.org/jira/browse/INFRA-27070
Request CSP exception for Giscus comments on datafusion.apache.org
--
This is an automated message from the Apache Gi
kevinjqliu commented on issue #80:
URL: https://github.com/apache/datafusion-site/issues/80#issuecomment-3114435954
I tried a few workarounds suggested by LLM, none of them worked
- use iframe
- download `giscus-client.js` and serve from repo
```
Refused to frame 'https://gis
kevinjqliu commented on issue #80:
URL: https://github.com/apache/datafusion-site/issues/80#issuecomment-3114367774
of course theres a CSP issue :P
https://datafusion.apache.org/blog/2025/07/16/datafusion-48.0.0/
```
Refused to load the script 'https://giscus.app/client.js' beca
alamb closed issue #80: Enable comments on datafusion-site via giscus
URL: https://github.com/apache/datafusion-site/issues/80
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
kevinjqliu commented on issue #80:
URL: https://github.com/apache/datafusion-site/issues/80#issuecomment-3066142358
I think this can only be done by the apache org admin, according to [github
docs](https://docs.github.com/en/apps/using-github-apps/installing-a-github-app-from-github-marketpl
alamb commented on issue #80:
URL: https://github.com/apache/datafusion-site/issues/80#issuecomment-3063612959
I didn't have permissions, but I could make a request which I did:
https://github.com/user-attachments/assets/3884c68a-4af5-4e94-94f1-59f9f5d102dc";
/>
--
This is an autom
kevinjqliu commented on issue #80:
URL: https://github.com/apache/datafusion-site/issues/80#issuecomment-3058031572
@alamb last item to make this work
> The giscus app is installed, otherwise visitors will not be able to
comment and react.
can you check if you have permission t
kevinjqliu commented on issue #80:
URL: https://github.com/apache/datafusion-site/issues/80#issuecomment-3050221253
i created an apache infra ticket to enable the giscus github app for this
repo
https://issues.apache.org/jira/browse/INFRA-26989
--
This is an automated message from the
kevinjqliu commented on issue #80:
URL: https://github.com/apache/datafusion-site/issues/80#issuecomment-3049458416
Opened #85 to turn on discussion for datafusion-site repo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
alamb commented on issue #80:
URL: https://github.com/apache/datafusion-site/issues/80#issuecomment-3049264127
> I've requested giscus to be installed for this repo
(apache/datafusion-site), waiting for approval.
> [@alamb](https://github.com/alamb) do you have permission to turn on
disc
kevinjqliu commented on issue #80:
URL: https://github.com/apache/datafusion-site/issues/80#issuecomment-3046273219
Giscus has 3 requirements
- [x] The repository is public, otherwise visitors will not be able to view
the discussion.
- [ ]The giscus app is installed, otherwise visitors
kevinjqliu commented on issue #80:
URL: https://github.com/apache/datafusion-site/issues/80#issuecomment-3045716736
@alamb could you take a look at #81 and #82 when you get a chance?
I also plan on creating a Makefile so running this repo locally can just be
a `make build`
--
This is
kevinjqliu commented on issue #80:
URL: https://github.com/apache/datafusion-site/issues/80#issuecomment-3045713260
cheers, i'll put up a PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
alamb commented on issue #80:
URL: https://github.com/apache/datafusion-site/issues/80#issuecomment-3044353421
> `giscus` works by creating a corresponding discussion thread for each post
and linking the comments in the thread.
> Heres an example,
[kevinjqliu/blog#3](https://github.com/k
kevinjqliu commented on issue #80:
URL: https://github.com/apache/datafusion-site/issues/80#issuecomment-3040039493
> I only worry that we won't see the comments and therefore won't respond.
Thats a good point. I think subscribing to the "Discussions" events on the
github repo will he
alamb commented on issue #80:
URL: https://github.com/apache/datafusion-site/issues/80#issuecomment-3039788072
Adding comments to the blog would be great -- I only worry that we won't see
the comments and therefore won't respond. Maybe we could make a git hub issue
or something for each blo
kevinjqliu opened a new issue, #80:
URL: https://github.com/apache/datafusion-site/issues/80
I think its beneficial to the community to add a comment section to the
datafusion blogs. Personally, I would like to have follow up discussions on the
blog post topic.
I found a possible so
21 matches
Mail list logo
